minor symfony#28864 [Process] A test case for stringifying of Process arguments (vudaltsov)

nicolas-grekas · nicolas-grekas · commit 55978d793f0d · 2018-10-14T11:39:46.000-07:00
This PR was merged into the 3.4 branch. Discussion ---------- [Process] A test case for stringifying of Process arguments | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | for symfony#28863 | License | MIT | Doc PR | Checks that non-string arguments passed to Process constructor are typecasted to string Commits ------- 0d54342 Add a test case for stringifying of Process arguments
diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php
@@ -1492,7 +1492,7 @@ public function testEscapeArgument($arg)
         $p = new Process(array(self::$phpBin, '-r', 'echo $argv[1];', $arg));
         $p->run();
 
-        $this->assertSame($arg, $p->getOutput());
+        $this->assertSame((string) $arg, $p->getOutput());
     }
 
     /**
@@ -1505,7 +1505,7 @@ public function testEscapeArgumentWhenInheritEnvDisabled($arg)
         $p->inheritEnvironmentVariables(false);
         $p->run();
 
-        $this->assertSame($arg, $p->getOutput());
+        $this->assertSame((string) $arg, $p->getOutput());
     }
 
     public function testRawCommandLine()
@@ -1535,6 +1535,9 @@ public function provideEscapeArgument()
         yield array("a!b\tc");
         yield array('a\\\\"\\"');
         yield array('éÉèÈàÀöä');
+        yield array(null);
+        yield array(1);
+        yield array(1.1);
     }
 
     public function testEnvArgument()
