bug symfony#25604 Add check for SecurityBundle in createAccessDeniedException (FGM)

Robin Chalas · Robin Chalas · commit 39f0438a0787 · 2017-12-29T14:31:25.000+01:00
This PR was submitted for the 4.0 branch but it was squashed and merged into the 3.4 branch instead (closes symfony#25604). Discussion ---------- Add check for SecurityBundle in createAccessDeniedException | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#25595 | License | MIT | Doc PR | n.a. Commits ------- a013c01 Add check for SecurityBundle in createAccessDeniedException
diff --git a/src/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.php b/src/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.php
@@ -366,10 +366,16 @@ protected function createNotFoundException($message = 'Not Found', \Exception $p
      *
      * @return AccessDeniedException
      *
+     * @throws \LogicException If SecurityBundle is not available
+     *
      * @final since version 3.4
      */
     protected function createAccessDeniedException($message = 'Access Denied.', \Exception $previous = null)
     {
+        if (!class_exists(AccessDeniedException::class)) {
+            throw new \LogicException('You can not use the "createAccessDeniedException" method if the SecurityBundle is not registered in your application. Try running "composer require security-core".');
+        }
+
         return new AccessDeniedException($message, $previous);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -366,10 +366,16 @@ protected function createNotFoundException($message = 'Not Found', \Exception $p`
`366`	`366`	`*`
`367`	`367`	`* @return AccessDeniedException`
`368`	`368`	`*`
	`369`	`+ * @throws \LogicException If SecurityBundle is not available`
	`370`	`+ *`
`369`	`371`	`* @final since version 3.4`
`370`	`372`	`*/`
`371`	`373`	`protected function createAccessDeniedException($message = 'Access Denied.', \Exception $previous = null)`
`372`	`374`	`{`
	`375`	`+ if (!class_exists(AccessDeniedException::class)) {`
	`376`	`+ throw new \LogicException('You can not use the "createAccessDeniedException" method if the SecurityBundle is not registered in your application. Try running "composer require security-core".');`
	`377`	`+ }`
	`378`	`+`
`373`	`379`	`return new AccessDeniedException($message, $previous);`
`374`	`380`	`}`
`375`	`381`