8000 Some questions/feedback about docs/usages · Issue #59 · dunglas/DunglasActionBundle · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Nov 15, 2018. It is now read-only.
This repository was archived by the owner on Nov 15, 2018. It is now read-only.
Some questions/feedback about docs/usages #59
@linaori

Description

@linaori

I have to admit, I've not used the package yet. Implementing this package in 1 applications is not done, would have to streamline it between apps, so here's some feedback as asked 😄

(1) I don't use autowiring so I will need to explicitly define the service definitions. I have a lot of Controllers already registered but not under the FQCN, would this register controllers twice?

(2) Why do I have to define the class AND the ID with the same value?

services:
    'AppBundle\Action\MyAction':
        # the class value looks obsolete, ID should already be sufficient right?
        class: 'AppBundle\Action\MyAction'
        arguments: [ '@router', '@twig' ]

(3) At the moment I define the service definitions via an annotation route loader and the SensioFrameworkExtraBundle: @Route(service="...").

This bundle also hooks into the Routing Component (if it is available): when the @Route annotation is used as in the example, the route is automatically registered: the bundle guesses the service to map with the path specified in the annotation.

Would this mean I can remove the class level service option for the @Route annotations?

I have a guess on what the "tag" configuration does, but it's not really well documented. Does the key mean it checks if the given class is a subclass of?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0