Simple refactor of ForEach functions (#323)

idichekop · web-flow · commit cb8d93c49975 · 2025-07-30T14:28:27.000+08:00
diff --git a/slice/slice.go b/slice/slice.go
@@ -507,19 +507,17 @@ func flattenRecursive(value reflect.Value, result reflect.Value) reflect.Value {
 }
 
 // ForEach iterates over elements of slice and invokes function for each element.
-// Play: https://go.dev/play/p/DrPaa4YsHRF
 func ForEach[T any](slice []T, iteratee func(index int, item T)) {
-	for i := 0; i < len(slice); i++ {
-		iteratee(i, slice[i])
+	for idx, elem := range slice {
+		iteratee(idx, elem)
 	}
 }
 
 // ForEachWithBreak iterates over elements of slice and invokes function for each element,
-// when iteratee return false, will break the for each loop.
-// Play: https://go.dev/play/p/qScs39f3D9W
+// when function return false, will break the for each loop.
 func ForEachWithBreak[T any](slice []T, iteratee func(index int, item T) bool) {
-	for i := 0; i < len(slice); i++ {
-		if !iteratee(i, slice[i]) {
+	for idx, elem := range slice {
+		if !iteratee(idx, elem) {
 			break
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -507,19 +507,17 @@ func flattenRecursive(value reflect.Value, result reflect.Value) reflect.Value {`
`507`	`507`	`}`
`508`	`508`
`509`	`509`	`// ForEach iterates over elements of slice and invokes function for each element.`
`510`		`-// Play: https://go.dev/play/p/DrPaa4YsHRF`
`511`	`510`	`func ForEach[T any](slice []T, iteratee func(index int, item T)) {`
`512`		`- for i := 0; i < len(slice); i++ {`
`513`		`- iteratee(i, slice[i])`
	`511`	`+ for idx, elem := range slice {`
	`512`	`+ iteratee(idx, elem)`
`514`	`513`	`}`
`515`	`514`	`}`
`516`	`515`
`517`	`516`	`// ForEachWithBreak iterates over elements of slice and invokes function for each element,`
`518`		`-// when iteratee return false, will break the for each loop.`
`519`		`-// Play: https://go.dev/play/p/qScs39f3D9W`
	`517`	`+// when function return false, will break the for each loop.`
`520`	`518`	`func ForEachWithBreak[T any](slice []T, iteratee func(index int, item T) bool) {`
`521`		`- for i := 0; i < len(slice); i++ {`
`522`		`- if !iteratee(i, slice[i]) {`
	`519`	`+ for idx, elem := range slice {`
	`520`	`+ if !iteratee(idx, elem) {`
`523`	`521`	`break`
`524`	`522`	`}`
`525`	`523`	`}`