10000 Add autocomplete to input screen by joshliebe · Pull Request #6280 · duckduckgo/Android · GitHub
[go: up one dir, main page]
Skip to content

Add autocomplete to input screen #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Add autocomplete to input screen #6280

merged 2 commits into from
Jun 26, 2025
+1,719 −27

Conversation

joshliebe
Copy link
Contributor
@joshliebe joshliebe commented Jun 24, 2025 •
edited by 0nko
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1210573023021041?focus=true

Description

  • Adds autocomplete to the input screen
  • Also changes the line height to 2 for both modes

Steps to test this PR

  • Enable “Search Input” in Settings > Duck.ai
  • Search for something
  • Verify autocomplete is shown
  • Tap on an autocomplete entry
  • Verify that the browser is opened with the query

@joshliebe Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe force-pushed the feature/josh/input-screen-autocomplete branch from 409711c to 23f0797 Compare June 26, 2025 16:27
@joshliebe joshliebe marked this pull request as ready for review June 26, 2025 16:30
@joshliebe joshliebe force-pushed the feature/josh/input-screen-autocomplete branch from 23f0797 to 7b6a7a9 Compare June 26, 2025 16:32
0nko
0nko approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member
@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works as expected 👍

@joshliebe joshliebe merged commit f42b839 into develop Jun 26, 2025
13 checks passed
@joshliebe joshliebe deleted the feature/josh/input-screen-autocomplete branch June 26, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0nko 0nko 0nko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshliebe @0nko
0