8000 Send active cohorts to broken report site by CrisBarreiro · Pull Request #6270 · duckduckgo/Android · GitHub
[go: up one dir, main page]

Skip to content

Send active cohorts to broken report site #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CrisBarreiro
Copy link
Contributor
@CrisBarreiro CrisBarreiro commented Jun 21, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1205008441501016/task/1209783667491175?focus=true

Description

Send active cohorts for C-S-S experiments to broken site report

Steps to test this PR

Feature 1

  • Set https://jsonblob.com/api/1381564551040000000 as RC URL
  • Load a site
  • Submit a broken site report
  • Check epbf pixel is fired and contains a parameter contentScopeExperiments with value bloops:{cohort},test:{cohort}. Note: cohorts are assigned randomly and therefore the value can't be predicted

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Copy link
Contributor Author
CrisBarreiro commented Jun 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro changed the title y Send active cohorts to broken report site Jun 23, 2025
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/css-experiments/send-active-cohorts-to-broken-site-report branch from 23a1ab7 to 6bd1ea0 Compare June 25, 2025 09:09
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/css-experiments/api-manipulation-integration-test branch from 466f05f to a40911e Compare June 26, 2025 15:09
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/css-experiments/send-active-cohorts-to-broken-site-report branch 2 times, most recently from 8e526a9 8000 to a9c3065 Compare June 26, 2025 15:16
@CrisBarreiro CrisBarreiro changed the base branch from feature/cris/css-experiments/api-manipulation-integration-test to feature/cris/css-experiments/send-api-manipulation-json June 26, 2025 15:16
@@ -1184,7 +1191,12 @@ class BrowserWebViewClientTest {
var countFinished = 0
var countStarted = 0

override fun onPageStarted(webView: WebView, url: String?, site: Site?) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing the site here because it was only used to check isDesktopMode. However, site isn't assigned until after onPageStarted is called, therefore it was null for new tabs, and contained old data for every subsequent page load. It still worked for isDesktopMode, because if site is null, we default to setting it as false, and every time we switch between desktop and mobile modes a page refresh is triggered, but can lead to confusion and issues for virtually any other site property

@CrisBarreiro CrisBarreiro marked this pull request as ready for review June 27, 2025 08:10
@anikiki anikiki self-assigned this Jun 27, 2025
Copy link
Contributor
@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 8000

Looks good and works as expected! 🎉

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/css-experiments/send-api-manipulation-json branch from 4bce050 to 08d754e Compare June 30, 2025 08:28
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/css-experiments/send-active-cohorts-to-broken-site-report branch from a9c3065 to 7d65d1e Compare June 30, 2025 08:28
@CrisBarreiro CrisBarreiro merged commit 7d65d1e into feature/cris/css-experiments/send-api-manipulation-json Jun 30, 2025
5 of 7 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/css-experiments/send-active-cohorts-to-broken-site-report branch June 30, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0