Omnibar position: Remove the feature flag #6240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy omnibar position feature flag logic and its related attribute matcher, streamlining the handling of omnibar position settings.
- Removed the omnibar position attribute matcher and feature flag observer classes.
- Deleted feature flag checks and related properties in BrowserTabViewModel and AppearanceViewModel.
- Updated AppearanceActivity to always display the omnibar position settings without feature flag gating.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| OmnibarPositionAttributeMatcher.kt | Deleted obsolete attribute matcher related to the feature flag. |
| OmnibarFeatureFlagObserver.kt | Removed observer responsible for updating omnibar position based on the feature flag. |
| BrowserTabViewModel.kt | Removed unused feature flag dependency and conditional logic updating omnibar view state. |
| AppearanceViewModel.kt | Removed feature flag dependency and associated state property from the view model. |
| AppearanceActivity.kt | Updated UI logic to remove feature flag condition and always display the omnibar position setting. |
Comments suppressed due to low confidence (1)
app/src/main/java/com/duckduckgo/app/appearance/AppearanceActivity.kt:145
- Consider updating documentation or adding comments to indicate that the omnibar position setting is now always visible, given the complete removal of the feature flag logic.
private fun updateSelectedOmnibarPosition(position: OmnibarPosition) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210556246664936?focus=true
Description
This PR removes the
omnibarPositionfeature flag and the "disabled" associated logical branches. It also removes the unused attribute matcher used by a remote configuration that's been long removed.Steps to test this PR
Smoke testing the omnibar position settings (Settings -> Appearance -> Position toggle) should be enough.