Avoid attribute() to fail on undefined object

Raphaël Droz · Raphaël Droz · commit ec635df5b9d8 · 2019-12-21T17:20:14.000-03:00
diff --git a/src/twig.functions.js b/src/twig.functions.js
@@ -188,7 +188,7 @@ module.exports = function (Twig) {
             }
 
             // Array will return element 0-index
-            return object[method] || undefined;
+            return object ? (object[method] || undefined) : undefined;
         },
         max(values, ...args) {
             if (Twig.lib.is('Object', values)) {
diff --git a/test/test.functions.js b/test/test.functions.js
@@ -274,6 +274,11 @@ describe('Twig.js Functions ->', function () {
                 })
                     .should.equal('');
             });
+
+            it('should return undef for undefined object', function () {
+                twig({data: '{{ attribute(arr, "bar") }}'}).render({})
+                    .should.equal('');
+            });
         });
         describe('template_from_string ->', function () {
             it('should load a template from a string', function () {

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ module.exports = function (Twig) {`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`// Array will return element 0-index`
`191`		`- return object[method] \|\| undefined;`
	`191`	`+ return object ? (object[method] \|\| undefined) : undefined;`
`192`	`192`	`},`
`193`	`193`	`max(values, ...args) {`
`194`	`194`	`if (Twig.lib.is('Object', values)) {`