Generalized git-specific code.

dsoprea · dsoprea · commit a2e354a04ef9 · 2014-03-23T20:39:48.000-04:00
diff --git a/src/get_versions.py b/src/get_versions.py
@@ -1,3 +1,4 @@
+import sys
 
 def get_root():
     try:
@@ -20,17 +21,27 @@ def get_versions(default=DEFAULT, verbose=False):
     root = get_root()
     versionfile_abs = os.path.join(root, versionfile_source)
 
+# TODO(dustin): Fix this comment to be VCS-agnostic.
     # extract version from first of _version.py, 'git describe', parentdir.
     # This is meant to work for developers using a source checkout, for users
     # of a tarball created by 'setup.py sdist', and for users of a
     # tarball/zipball created by 'git archive' or github's download-from-tag
     # feature.
 
-    if VCS == "git":
-        ver = git_versions_from_keywords(git_get_keywords(versionfile_abs),
-                                         tag_prefix)
-    else:
+    def vcs_function(vcs, suffix):
+        return getattr(sys.modules[__name__], '%s_%s' % (vcs, suffix))
+
+    try:
+        get_keywords_f = vcs_function(VCS, 'get_keywords')
+        vcs_keywords = get_keywords_f(versionfile_abs)
+
+        versions_from_keywords_f = vcs_function(VCS, 'versions_from_keywords')
+        ver = versions_from_keywords_f(vcs_keywords, tag_prefix)
+    except AttributeError:
+# TODO(dustin): We used to take Non when the VCS was unknown. Now we'll only 
+# take None if the VCS-specific function isn't defined. Is this okay?
         ver = None
+
     if ver:
         if verbose: print("got version from expanded keyword %s" % ver)
         return ver
@@ -40,12 +51,16 @@ def get_versions(default=DEFAULT, verbose=False):
         if verbose: print("got version from file %s %s" % (versionfile_abs,ver))
         return ver
 
-    if VCS == "git":
-        ver = git_versions_from_vcs(tag_prefix, root, verbose)
-    else:
+    try:
+        versions_from_vcs_f = vcs_function(VCS, 'versions_from_vcs')
+        ver = versions_from_vcs_f(tag_prefix, root, verbose)
+    except AttributeError:
+# TODO(dustin): We used to take Non when the VCS was unknown. Now we'll only 
+# take None if the VCS-specific function isn't defined. Is this okay?
         ver = None
+
     if ver:
-        if verbose: print("got version from git %s" % ver)
+        if verbose: print("got version from VCS %s" % ver)
         return ver
 
     ver = versions_from_parentdir(parentdir_prefix, root, verbose)
