10000 docs(return-await): remove return-await from recommended rules · drabinowitz/typescript-eslint@7fbe46b · GitHub
[go: up one dir, main page]

Skip to content

Commit 7fbe46b

Browse files
committed
docs(return-await): remove return-await from recommended rules
return-await is not a recommended rule for users as part of default typescript-eslint setup. re typescript-eslint#994
1 parent 73db70a commit 7fbe46b

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

packages/eslint-plugin/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ Then you should add `airbnb` (or `airbnb-base`) to your `extends` section of `.e
204204
| [`@typescript-eslint/require-await`](./docs/rules/require-await.md) | Disallow async functions which have no `await` expression | :heavy_check_mark: | | :thought_balloon: |
205205
| [`@typescript-eslint/restrict-plus-operands`](./docs/rules/restrict-plus-operands.md) | When adding two variables, operands must both be of type number or of type string | | | :thought_balloon: |
206206
| [`@typescript-eslint/restrict-template-expressions`](./docs/rules/restrict-template-expressions.md) | Enforce template literal expressions to be of string type | | | :thought_balloon: |
207-
| [`@typescript-eslint/return-await`](./docs/rules/return-await.md) | Rules for awaiting returned promises | :heavy_check_mark: | | :thought_balloon: |
207+
| [`@typescript-eslint/return-await`](./docs/rules/return-await.md) | Rules for awaiting returned promises | | | :thought_balloon: |
208208
| [`@typescript-eslint/semi`](./docs/rules/semi.md) | Require or disallow semicolons instead of ASI | | :wrench: | |
209209
| [`@typescript-eslint/space-before-function-paren`](./docs/rules/space-before-function-paren.md) | enforce consistent spacing before `function` definition opening parenthesis | | :wrench: | |
210210
| [`@typescript-eslint/strict-boolean-expressions`](./docs/rules/strict-boolean-expressions.md) | Restricts the types allowed in boolean expressions | | | :thought_balloon: |

packages/eslint-plugin/src/configs/recommended-requiring-type-checking.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"@typescript-eslint/prefer-string-starts-ends-with": "error",
1111
"require-await": "off",
1212
"@typescript-eslint/require-await": "error",
13-
"@typescript-eslint/return-await": "error",
1413
"@typescript-eslint/unbound-method": "error",
1514
"no-var": "error",
1615
"prefer-const": "error",

packages/eslint-plugin/src/rules/return-await.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default util.createRule({
1212
docs: {
1313
description: 'Rules for awaiting returned promises',
1414
category: 'Best Practices',
15-
recommended: 'error',
15+
recommended: false,
1616
requiresTypeChecking: true,
1717
},
1818
type: 'problem',

0 commit comments

Comments
 (0)
0