[FrameworkBundle] removed links in exceptions when the file does not exist (mostly useful because of shortcut notations for templates)

fabpot · fabpot · commit d873f21f69c9 · 2011-04-12T15:23:02.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Templating/Helper/CodeHelper.php b/src/Symfony/Bundle/FrameworkBundle/Templating/Helper/CodeHelper.php
@@ -189,7 +189,11 @@ public function formatFile($file, $line, $text = null)
      */
     public function getFileLink($file, $line)
     {
-        return $this->fileLinkFormat ? strtr($this->fileLinkFormat, array('%f' => $file, '%l' => $line)) : false;
+        if ($this->fileLinkFormat && file_exists($file)) {
+            return strtr($this->fileLinkFormat, array('%f' => $file, '%l' => $line));
+        }
+
+        return false;
     }
 
     public function formatFileFromText($text)

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,11 @@ public function formatFile($file, $line, $text = null)`
`189`	`189`	`*/`
`190`	`190`	`public function getFileLink($file, $line)`
`191`	`191`	`{`
`192`		`- return $this->fileLinkFormat ? strtr($this->fileLinkFormat, array('%f' => $file, '%l' => $line)) : false;`
	`192`	`+ if ($this->fileLinkFormat && file_exists($file)) {`
	`193`	`+ return strtr($this->fileLinkFormat, array('%f' => $file, '%l' => $line));`
	`194`	`+ }`
	`195`	`+`
	`196`	`+ return false;`
`193`	`197`	`}`
`194`	`198`
`195`	`199`	`public function formatFileFromText($text)`