Remove unused arch-specific properties #10899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused x64-specific version properties and dependencies to streamline version management.
- Drop x64-specific package version properties from eng/Versions.props
- Remove corresponding runtime and shared-framework dependencies from eng/Version.Details.xml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Removed VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion and MicrosoftNETCoreAppRuntimewinx64Version properties |
| eng/Version.Details.xml | Removed <Dependency> entries for Microsoft.NETCore.App.Runtime.win-x64 and VS.Redist.Common.NetCore.SharedFramework.x64.10.0 |
Comments suppressed due to low confidence (3)
eng/Versions.props:33
- [nitpick] Consider adding an XML comment explaining why the x64-specific package version properties were removed to maintain historical context.
<VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion>10.0.0-preview.6.25278.103</VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion>
eng/Versions.props:33
- Verify that other architecture-specific properties (e.g., ARM or x86) are also removed or updated if they are similarly unused to keep this file consistent.
<VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion>10.0.0-preview.6.25278.103</VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion>
eng/Version.Details.xml:39
- Add or update integration tests to verify that removing these runtime dependencies doesn't impact version resolution or package graph generation.
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="10.0.0-preview.6.25278.103">
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10899 +/- ##
===========================================
Coverage 2.98814% 2.98814%
===========================================
Files 3319 3319
Lines 664895 664895
Branches 74675 74675
===========================================
Hits 19868 19868
Misses 644846 644846
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ViktorHofer
previously approved these changes
Jun 2, 2025
|
@dotnet/wpf-developers PTAL |
ViktorHofer
approved these changes
Jun 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow