8000 Fixed ToolTip Fluent Style and Resources by dipeshmsft · Pull Request #10863 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Fixed ToolTip Fluent Style and Resources #10863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Fixed ToolTip Fluent Style and Resources #10863

merged 2 commits into from
May 22, 2025

Conversation

dipeshmsft
Copy link
Member
@dipeshmsft dipeshmsft commented May 21, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #9672

Description

Fixes issues in ToolTip style : including resource naming, some values and layout

Customer Impact

Correct style for ToolTip

Regression

N/A

Testing

Local

Risk

Minimal.
\

Microsoft Reviewers: Open in CodeFlow

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 05:45
@dipeshmsft dipeshmsft requested a review from a team as a code owner May 21, 2025 05:45
@dipeshmsft dipeshmsft requested a review from harshit7962 May 21, 2025 05:45
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label May 21, 2025
Copilot
Copilot AI reviewed May 21, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several layout and resource naming issues with the ToolTip style in the Fluent themes, ensuring that the ToolTip appears correctly across light, high-contrast, and dark modes. Key changes include renaming and adding new resource keys for ToolTip backgrounds and foregrounds, updating style setters (such as setting FontWeight and adjusting VerticalContentAlignment), and modifying the ControlTemplate for ToolTip.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Fluent.Light.xaml Updated ToolTip resource keys and adjusted DefaultToolTipStyle setters for improved layout and visual consistency.
Fluent.HC.xaml Applied similar resource renaming and style modifications to the high-contrast theme.
Fluent.Dark.xaml Revised ToolTip styling including resource key updates and alignment modifications.
ToolTip.xaml Aligned ToolTip style setters with the new resource naming conventions.
Light.xaml Updated resource definitions for ToolTip backgrounds and foregrounds in the light theme.
HC.xaml Revised ToolTip resource definitions for the high-contrast theme.
Dark.xaml Updated ToolTip resource definitions for the dark theme.

@codecov Codecov
Copy link
codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.41971%. Comparing base (dcf162f) to head (d82fc5d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #10863         +/-   ##
===================================================
- Coverage   13.52048%   13.41971%   -0.10077%     
===================================================
  Files           3319        3319                 
  Lines         664895      664895                 
  Branches       74675       74675                 
===================================================
- Hits           89897       89227        -670     
- Misses        572455      573123        +668     
- Partials        2543        2545          +2
Flag Coverage Δ
Debug 13.41971% <ø> (-0.10077%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshit7962 harshit7962 self-assigned this May 21, 2025
@dipeshmsft dipeshmsft force-pushed the fluent/bugs/tooltip-resource-naming-fix branch from 5224da3 to e9de8d9 Compare May 21, 2025 07:29
harshit7962
harshit7962 approved these changes May 22, 2025
View reviewed changes
Copy link
Member
@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving changes.

@dipeshmsft dipeshmsft merged commit 1ed9bb1 into dotnet:main May 22, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@harshit7962 harshit7962 harshit7962 approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@Kuldeep-MS Kuldeep-MS Awaiting requested review from Kuldeep-MS

Assignees

@harshit7962 harshit7962

@dipeshmsft dipeshmsft

Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fluent2 Using Old/Incorrect ResourceKeys (Example ToolTip)
3 participants
@dipeshmsft @harshit7962 @pegasus-lynx
0