Keep the Button HorizontalAlignment be Stretch in Fluent style #10082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lindexi Run the theme generator ( |
|
@lindexi both HorizontalAlignment and VerticalAlignment should be Stretch, or rather we can just remove them, as the default value is Stretch. Can you make the above changes ? Once that is done, we need to run |
53707e8 to
0eda36c
Compare
|
@dipeshmsft OK, I update it. |
lindexi
added a commit
to lindexi/lindexi_gd
that referenced
this pull request
May 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10082 +/- ##
===================================================
+ Coverage 13.43439% 13.47351% +0.03911%
===================================================
Files 3317 3317
Lines 664749 664749
Branches 74643 74643
===================================================
+ Hits 89305 89565 +260
+ Misses 572854 572582 -272
- Partials 2590 2602 +12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10077
Description
In the Fluent style, ensure that the
HorizontalAlignmentproperty of buttons is set toCenter. This helps maintain consistent behavior with previous styles.Customer Impact
Maintaining consistent behavior allows developers to more easily apply the Fluent theme without worrying about layout changes due to style switches.
Regression
See #8870
Testing
Just CI and Snoop
Risk
Low. This potentially breaking scenarios where buttons relying on the Fluent style are left-aligned. Therefore, I believe the sooner this change is merged, the lower the risk will be, as fewer developers will depend on buttons being left-aligned.
Microsoft Reviewers: Open in CodeFlow