10000 Try replacing FluentAssertions by danmoseley · Pull Request #13108 · dotnet/winforms · GitHub
[go: up one dir, main page]
Skip to content

Try replacing FluentAssertions #13108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

Try replacing FluentAssertions #13108

merged 3 commits into from
Mar 12, 2025

Conversation

danmoseley
Copy link
Member
@danmoseley danmoseley commented Mar 11, 2025 •
edited
Loading

Context: fluentassertions/fluentassertions#2943

Note that code didn't change - namespace is the same.
Didn't try building/running tests

cc @Tanya-Solyanik @artl93 @marcpopMSFT @rainersigwald

Microsoft Reviewers: Open in CodeFlow

@danmoseley danmoseley requested a review from a team as a code owner March 11, 2025 17:52
@danmoseley danmoseley closed this Mar 11, 2025
@danmoseley danmoseley reopened this Mar 11, 2025
@danmoseley
Copy link
Member Author

Mirroring completed

@Tanya-Solyanik would this run all the relevant tests?

@Tanya-Solyanik
Copy link
Contributor

@danmoseley - yes, this should run all tests

@codecov Codecov
Copy link
codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.28594%. Comparing base (ed95d3b) to head (e72b178).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #13108         +/-   ##
===================================================
+ Coverage   61.26825%   61.28594%   +0.01768%     
===================================================
  Files           1541        1541                 
  Lines         158281      158281                 
  Branches       14743       14743                 
===================================================
+ Hits           96976       97004         +28     
+ Misses         60607       60579         -28     
  Partials         698         698
Flag Coverage Δ
Debug 61.28594% <50.00000%> (+0.01768%) ⬆️
integration 10.73667% <ø> (-0.00105%) ⬇️
production 39.15432% <ø> (+0.02908%) ⬆️
test 95.67280% <50.00000%> (ø)
unit 36.57698% <ø> (+0.02906%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Tanya-Solyanik
Tanya-Solyanik approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor
@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests pass in VS too

@Tanya-Solyanik Tanya-Solyanik merged commit 866c869 into dotnet:main Mar 12, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Mar 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Assignees

@danmoseley danmoseley

Labels
None yet
Projects
None yet
Milestone
10.0 Preview3
Development

Successfully merging this pull request may close these issues.
2 participants
@danmoseley @Tanya-Solyanik
0