8000 Use SB validation jobs in PR builds the same way as official builds · Issue #5202 · dotnet/source-build · GitHub
[go: up one dir, main page]

Skip to content

Use SB validation jobs in PR builds the same way as official builds #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mthalman opened this issue May 16, 2025 · 1 comment
Open
Labels
area-infra Source-build infrastructure and reporting

Comments

@mthalman
Copy link
Member

Today SB jobs in PR builds run tests in the same job that the build occurs. But in official builds, the tests run in a separate job because it also requires artifacts from other jobs. We should follow the same pattern of a separate validation job for PR builds as well, even though it only requires the output of the SB job.

This will make the functionality of the pipeline more consistent. It will also prevent issues like #5198 which worked in a PR build but failed in the official build.

@MichaelSimons MichaelSimons added area-infra Source-build infrastructure and reporting and removed untriaged labels May 22, 2025
@MichaelSimons
Copy link
Member

[Triage] One concern here is that with the work to support repo level VMR/SB validation legs is sensitive to the overall time to run the SB legs. We want to keep this to a minimum. It may be the case that we should continue to run build/validation together in these repo scenarios. The main problem they would face is the delay in acquiring a build agent to run the validation stage. In the VMR validation, this is not a concern because the vertical legs are longer.

@MichaelSimons MichaelSimons moved this from Backlog to 10.0 in .NET Source Build May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
Status: 10.0
Development

No branches or pull requests

2 participants
0