8000 Truncated test failure messages · Issue #5141 · dotnet/source-build · GitHub
[go: up one dir, main page]
Skip to content

Truncated test failure messages #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelSimons opened this issue May 6, 2025 · 0 comments · Fixed by dotnet/dotnet#551
Closed

Truncated test failure messages #5141

MichaelSimons opened this issue May 6, 2025 · 0 comments · Fixed by dotnet/dotnet#551
Assignees
@NikolaMilosavljevic
Labels
area-testing Improvements in CI and testing

Comments

@MichaelSimons
Copy link
Member

The UX is less than ideal when there is a test failure in the BaselineHelper. This is an examples from #5122:

Assert.Null() Failure: Value is not null
Expected: null
Actual:   "\nExpected file '/__w/1/s/artifacts/bin/Microsoft."···

The assert used here is Assert.Null(message);

A quick search suggests this is a known truncation. The recommendation is to use the following pattern instead:

Assert.True(message == null, message);

This suggestion should be vetted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-testing Improvements in CI and testing
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error message truncation NikolaMilosavljevic/dotnet-vmr
2 participants
@MichaelSimons @NikolaMilosavljevic
0