8000 launchSettings workingDirectory overrides project settings · dotnet/sdk@08447b3 · GitHub
[go: up one dir, main page]
Skip to content

Commit 08447b3

Browse files
skybaksskybaks
committed
launchSettings workingDirectory overrides project settings
1 parent b9c5846 commit 08447b3

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

‎src/Cli/dotnet/commands/dotnet-run/RunCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ private ICommand ApplyLaunchSettingsProfileToCommand(ICommand targetCommand, Pro
109109
{
110110
targetCommand.SetCommandArgs(launchSettings.CommandLineArgs);
111111
}
112-
if (string.IsNullOrEmpty(targetCommand.CommandWorkingDirectory) && launchSettings.WorkingDirectory != null)
112+
if (launchSettings.WorkingDirectory != null)
113113
{
114114
targetCommand.WorkingDirectory(launchSettings.WorkingDirectory);
115115
}

‎test/dotnet-run.Tests/GivenDotnetRunBuildsCsProj.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ public void ItUsesTheValueOfAppUrlIfTheEnvVarIsNotSet()
562562
}
563563

564564
[Fact]
565-
public void ItUsesTheValueOfWorkingDirectoryIfTheProjectRunWorkingDirectoryIsNotSet()
565+
public void ItUsesTheValueOfWorkingDirectoryIfSet()
566566
{
567567
var testAppName = "AppWithWorkingDirectoryInLaunchSettings";
568568
var testInstance = _testAssetsManager.CopyTestAsset(testAppName)
@@ -583,27 +583,27 @@ public void ItUsesTheValueOfWorkingDirectoryIfTheProjectRunWorkingDirectoryIsNot
583583
}
584584

585585
[Fact]
586-
public void ItPrefersTheValueOfProjectRunWorkingDirectoryIfSet()
586+
public void ItPrefersTheValueOfWorkingDirectoryFromLaunchSettingsOverProjectRunWorkingDirectory()
587587
{
588588
var testAppName = "AppWithWorkingDirectoryInLaunchSettings";
589589
var testInstance = _testAssetsManager.CopyTestAsset(testAppName)
590590
.WithSource()
591591
.WithProjectChanges(p => {
592592
var ns = p.Root.Name.Namespace;
593593
var propertyGroup = p.Root.Elements(ns + "PropertyGroup").First();
594-
propertyGroup.Add(new XElement(ns + "RunWorkingDirectory", "runSubfolder"));
594+
propertyGroup.Add(new XElement(ns + "RunWorkingDirectory", "expectThisSubfolderIsOverridden"));
595595
});
596596

597597
var testProjectDirectory = testInstance.Path;
598598

599-
Directory.CreateDirectory(Path.Combine(testProjectDirectory, "runSubfolder"));
599+
Directory.CreateDirectory(Path.Combine(testProjectDirectory, "launchSubfolder"));
600600

601601
var cmd = new DotnetCommand(Log, "run")
602602
.WithWorkingDirectory(testProjectDirectory)
603603
.Execute("--launch-profile", "Second");
604604

605605
cmd.Should().Pass()
606-
.And.HaveStdOutContaining("runSubfolder");
606+
.And.HaveStdOutContaining("launchSubfolder");
607607

608608
cmd.StdErr.Should().BeEmpty();
609609
}

0 commit comments

Comments
 (0)
0