8000 Fix SdkResultFactory conflicting parameters (#12107) · dotnet/msbuild@194c2e9 · GitHub
[go: up one dir, main page]
Skip to content

Commit 194c2e9

Browse files
YuliiaKovalovaYuliiaKovalova
authored
Fix SdkResultFactory conflicting parameters (#12107)
1 parent ec93eaa commit 194c2e9

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

‎src/Build/BackEnd/Components/SdkResolution/SdkResultFactory.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ public override SdkResultBase IndicateSuccess(string path,
4444

4545
public override SdkResultBase IndicateSuccess(IEnumerable<string> paths,
4646
string version,
47-
IDictionary<string, string> propertiesToAdd = null,
48-
IDictionary<string, SdkResultItem> itemsToAdd = null,
49-
IEnumerable<string> warnings = null)
47+
IDictionary<string, string> propertiesToAdd,
48+
IDictionary<string, SdkResultItem> itemsToAdd,
49+
IEnumerable<string> warnings)
5050
{
5151
return new SdkResult(_sdkReference, paths, version, propertiesToAdd, itemsToAdd, warnings);
5252
}

‎src/Framework/Sdk/SdkResultFactory.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ public virtual SdkResult IndicateSuccess(string path,
5454
/// <param name="version">SDK version which should be imported</param>
5555
/// <param name="propertiesToAdd">Properties to set in the evaluation</param>
5656
/// <param name="itemsToAdd">Items to add to the evaluation</param>
57-
/// <param name="warnings">Optional warnings to display during resolution.</param>
57+
/// <param name="warnings">Warnings to display during resolution.</param>
5858
/// <returns></returns>
5959
public virtual SdkResult IndicateSuccess(IEnumerable<string> paths,
6060
string version,
61-
IDictionary<string, string> propertiesToAdd = null,
62-
IDictionary<string, SdkResultItem> itemsToAdd = null,
63-
IEnumerable<string> warnings = null)
61+
IDictionary<string, string> propertiesToAdd,
62+
IDictionary<string, SdkResultItem> itemsToAdd,
63+
IEnumerable<string> warnings)
6464
{
6565
throw new NotImplementedException();
6666
}

0 commit comments

Comments
 (0)
0