8000 [vs17.14] Binlog not produced for C++ project on Visual Studio Load F… · dotnet/msbuild@18a02f8 · GitHub
[go: up one dir, main page]
Skip to content

Commit 18a02f8

Browse files
surayya-MSsurayya-MS
authored
[vs17.14] Binlog not produced for C++ project on Visual Studio Load Fix (#11774)
A refactor to use collection expressions (eae7bbd) accidentally changed behavior on these lines--instead of appending to an existing list, the to-be-appended entries were used only if the existing list was `null`. Fixes #11678.
1 parent fc19b05 commit 18a02f8

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

‎eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
33
<Project>
44
<PropertyGroup>
5-
<VersionPrefix>17.14.4</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind>
5+
<VersionPrefix>17.14.7</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind>
66
<PackageValidationBaselineVersion>17.13.9</PackageValidationBaselineVersion>
77
<AssemblyVersion>15.1.0.0</AssemblyVersion>
88
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>

‎src/Build/BackEnd/BuildManager/BuildManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,7 @@ IEnumerable<ILogger> AppendDebuggingLoggers(IEnumerable<ILogger> loggers)
677677

678678
var logger = new BinaryLogger { Parameters = binlogPath };
679679

680-
return (loggers ?? [logger]);
680+
return (loggers ?? []).Concat([logger]);
681681
}
682682

683683
void InitializeCaches()

‎src/Tasks/GenerateResource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1705,7 +1705,7 @@ private void UpdateNewestUncorrelatedInputWriteTime()
17051705

17061706
// Check the timestamp of each of the passed-in references to find the newest;
17071707
// and then the additional inputs
1708-
ITaskItem[] inputs = this.References ?? [.. (this.AdditionalInputs ?? [])];
1708+
var inputs = (this.References ?? []).Concat(this.AdditionalInputs ?? []);
17091709

17101710
foreach (ITaskItem input in inputs)
17111711
{

0 commit comments

Comments
 (0)
0