10000 Microsoft.Data.Analysis.DataFrame Join should produce a result with a single joined column · Issue #6133 · dotnet/machinelearning · GitHub
[go: up one dir, main page]
Skip to content

Microsoft.Data.Analysis.DataFrame Join should produce a result with a single joined column #6133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #6144
olavt opened this issue Mar 17, 2022 · 4 comments
Open
Tracked by #6144

Microsoft.Data.Analysis.DataFrame Join should produce a result with a single joined column #6133

olavt opened this issue Mar 17, 2022 · 4 comments
Labels
enhancement New feature or request Microsoft.Data.Analysis All DataFrame related issues and PRs P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Milestone
ML.NET 3.0

Comments

@olavt
Copy link
olavt commented Mar 17, 2022

Given two DataFame objects it should be easy to perform a simple outer join to achieve these results:

DataFrame1:

Date ClosePrice
3/1/2022 12:00:00 AM 10.5
3/2/2022 12:00:00 AM 12.4
3/3/2022 12:00:00 AM 11.3

DataFrame2:

Date ShortPercent
3/1/2022 12:00:00 AM 2.34
3/2/2022 12:00:00 AM 2.36
3/3/2022 12:00:00 AM 3.01
3/4/2022 12:00:00 AM 3.04

Resulting DataFrame:

Date ClosePrice ShortPercent
3/1/2022 12:00:00 AM 10.5 2.34
3/2/2022 12:00:00 AM 12.4 2.36
3/3/2022 12:00:00 AM 11.3 3.01
3/4/2022 12:00:00 AM null 3.04

This does not seem to be possible with the current Merge or Join methods, since they end up with two columns for Date (Date_left and Date_right) in the resulting DataFrame and combining those to a single column seems complex and error prone.
@olavt olavt added the enhancement New feature or request label Mar 17, 2022
@ghost ghost added the untriaged New issue has not been triaged label Mar 17, 2022
@michaelgsharp michaelgsharp added P2 Priority of the issue for triage purpose: Needs to be fixed at some point. Microsoft.Data.Analysis All DataFrame related issues and PRs and removed untriaged New issue has not been triaged labels Mar 18, 2022
@michaelgsharp michaelgsharp added this to the ML.NET Future milestone Mar 18, 2022
@michaelgsharp
Copy link
Contributor

Thanks for pointing this out @olavt. This is the same issue that you and I were talking about right @luisquintanilla?

@luisquintanilla
Copy link
Contributor

Thanks for pointing this out @olavt. This is the same issue that you and I were talking about right @luisquintanilla?

Yup. That's right. Related to #6128.

@luisquintanilla luisquintanilla mentioned this issue Mar 30, 2022
Open
37 tasks
@beccamc beccamc mentioned this issue Jun 9, 2022
Open
8 tasks
@Nils12345678901234567
Copy link

I would regard this as a bug, not an enhanment. The Merge and Join methods deos nor work as expected.

@gusmally
Copy link

I am surprised that this bug is still open-- this is basic functionality. Implementing this would go a long way in enabling developers to use DataFrames in C#!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Microsoft.Data.Analysis All DataFrame related issues and PRs P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Milestone
ML.NET 3.0
Development

No branches or pull requests
5 participants
@olavt @gusmally @luisquintanilla @michaelgsharp @Nils12345678901234567
0