8000 Add back net9.0 version of the aieval dotnet tool (#6396) · dotnet/extensions@91eabd6 · GitHub
[go: up one dir, main page]
Skip to content

Commit 91eabd6

Browse files
shyamnamboodiripadshyamnamboodiripad
authored
Add back net9.0 version of the aieval dotnet tool (#6396)
In #6148, we disabled net9.0 TFM for the aieval tool to work around the race described in dotnet/sdk#47696. The underlying issue was subsequently fixed in the SDK (via dotnet/sdk#47788). However, this fix has not been backported to the dotnet 9 SDK yet. The SDK team is working on backporting the fix (see discussion in dotnet/sdk#47788 (comment)). But in the meanwhile, we can add back the net9.0 TFM and continue to work around the race by disabling parallel build. This would help users of the aieval tool sidestep errors such as the ones described in #6388 when they dont have dotnet8 installed on the machine. We can remove this workaround, once the backported fix is available in the dotnet 9 SDK. Fixes #6388
1 parent 3b12514 commit 91eabd6

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

‎src/Libraries/Microsoft.Extensions.AI.Evaluation.Console/Microsoft.Extensions.AI.Evaluation.Console.csproj

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
<PropertyGroup>
44
<Description>A command line dotnet tool for generating reports and managing evaluation data.</Description>
55
<OutputType>Exe</OutputType>
6-
<!-- Building only one TFM due to bug: https://github.com/dotnet/sdk/issues/47696
7-
Once this is fixed, we can go back to building multiple. -->
8-
<TargetFrameworks>$(MinimumSupportedTfmForPackaging)</TargetFrameworks>
6+
<TargetFrameworks>$(NetCoreTargetFrameworks)</TargetFrameworks>
97
<RootNamespace>Microsoft.Extensions.AI.Evaluation.Console</RootNamespace>
108
<!-- EA0000: Use source generated logging methods for improved performance. -->
119
<NoWarn>$(NoWarn);EA0000</NoWarn>
@@ -22,6 +20,15 @@
2220
<MinMutationScore>0</MinMutationScore>
2321
</PropertyGroup>
2422

23+
<!--
24+
Disable parallel build to work around https://github.com/dotnet/sdk/issues/47696. The problem has been fixed in
25+
https://github.com/dotnet/sdk/pull/47788, however the fix has not yet been back ported to the dotnet 9 SDK. We can
26+
remove this workaround once the fix is available in the dotnet 9 SDK.
27+
-->
28+
<PropertyGroup>
29+
<BuildInParallel>false</BuildInParallel>
30+
</PropertyGroup>
31+
2532
<ItemGroup>
2633
<PackageReference Include="Azure.Identity" />
2734
<PackageReference Include="Azure.Storage.Files.DataLake" />

0 commit comments

Comments
 (0)
0