Address PR review feedback: Remove unnecessary pool clearing and make cross-platform file handle leak test

Copilot · cincuranet · Copilot · commit eb2f7b1b456d · 2025-06-02T16:59:39.000Z
Co-authored-by: cincuranet &lt;4540597+cincuranet@users.noreply.github.com&gt;
diff --git a/test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs b/test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs
@@ -1315,18 +1315,13 @@ public void Open_releases_handle_when_constructor_fails()
             
             Assert.Equal(ConnectionState.Closed, connection.State);
 
-            // Clear any pools that might hold connections
-            SqliteConnection.ClearPool(connection);
-
-            // The file should be movable/deletable now (indicating handle was released)
-            // If there's a file handle leak, this will fail on Windows
-            var tempPath = dbPath + ".moved";
-            File.Move(dbPath, tempPath);
-            File.Delete(tempPath);
+            // The file should be deletable now (indicating handle was released)
+            // If there's a file handle leak, this will fail
+            File.Delete(dbPath);
         }
         finally
         {
-            // Clean up
+            // Clean up - file may already be deleted by the test
             if (File.Exists(dbPath))
             {
                 File.Delete(dbPath);
@@ -1355,9 +1350,6 @@ public void Open_releases_handle_when_opening_invalid_file()
             // Should be some kind of error - we don't care about the specific code
             Assert.True(ex.SqliteErrorCode != 0);
             Assert.Equal(ConnectionState.Closed, connection.State);
-
-            // Clear any pools that might hold connections
-            SqliteConnection.ClearPool(connection);
         }
         finally
         {
