8000 Update with latest mdoc changes + .NET Core 2.1 Preview 1 by dend · Pull Request #7 · dotnet/dotnet-api-docs · GitHub
[go: up one dir, main page]

Skip to content

Update with latest mdoc changes + .NET Core 2.1 Preview 1 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2018
Merged

Conversation

dend
Copy link
Contributor
@dend dend commented Apr 2, 2018

No description provided.

@mairaw mairaw changed the title Update with latest changes Update with latest mdoc changes + .NET Core 2.1 Preview 1 Apr 2, 2018
@mairaw mairaw merged commit 2a2448a into master Apr 2, 2018
@mairaw mairaw deleted the CITest branch April 2, 2018 22:13
@mairaw mairaw added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Apr 3, 2018
@wstaelens
Copy link

@mairaw https://docs.microsoft.com/nl-be/dotnet/api/system.text.regularexpressions.groupcollection?view=netframework-4.7.1

In the examples section: you have "The example displays the following output:"
but this is not complete as it doesn't show all console.writeline information etc...

the example should show the exact output that the code has.

@mairaw
Copy link
Contributor
mairaw commented Jul 3, 2018

@wstaelens I only noticed your message now. Are you still having issues with that page?

@wstaelens
Copy link

well if you execute that code the console.writeline doesn't 100% match the comments // in the code describing the output ;-)

@mairaw
Copy link
Contributor
mairaw commented Jul 3, 2018

I misunderstood your earlier comment then. Can you open an issue at https://github.com/dotnet/docs with this information for us to track this? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0