From 77399c7c5b059be7097143c0d2c5f658db9e90c7 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Wed, 2 Sep 2020 16:47:43 +0200 Subject: [PATCH 01/20] Draft for @manickap --- xml/System.Net.Http/ByteArrayContent.xml | 17 ++++++++++++----- xml/System.Net.Http/HttpClient.xml | 24 ++++++++++++++++++++---- 2 files changed, 32 insertions(+), 9 deletions(-) diff --git a/xml/System.Net.Http/ByteArrayContent.xml b/xml/System.Net.Http/ByteArrayContent.xml index a2e84f09999..970f6924f73 100644 --- a/xml/System.Net.Http/ByteArrayContent.xml +++ b/xml/System.Net.Http/ByteArrayContent.xml @@ -226,11 +226,18 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The target stream. + Information about the transport, like channel binding token. This parameter may be . + The cancellation token to cancel the operation. + Serialize and write the byte array provided in the constructor to an HTTP content stream as a synchronous operation. + + + diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 2b181b67acf..7943d5c3646 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2686,10 +2686,26 @@ The is not an absolute URI. - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send. + Send an HTTP request as a synchronous operation. + HTTP response message. + + [!NOTE] +> In case of timeout, different exceptions are thrown on different .NET implementations. +> - is thrown on all applicable .NET Framework versions. +> - without any inner exception is thrown on all applicable .NET Core versions. +> - that nests a is thrown on .NET 5.0 and later versions. + ]]> + + The is . + The request message was already sent by the instance. + The request failed due to an underlying issue such as network connectivity, DNS failure, server certificate validation or timeout. + .NET Core and .NET 5.0 and later only: The request failed due to timeout. From 680ef84c1f436674bc0822db51e23e662191fb59 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Thu, 3 Sep 2020 11:34:21 +0200 Subject: [PATCH 02/20] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com> --- xml/System.Net.Http/ByteArrayContent.xml | 2 +- xml/System.Net.Http/HttpClient.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Http/ByteArrayContent.xml b/xml/System.Net.Http/ByteArrayContent.xml index 970f6924f73..19a3f50fab0 100644 --- a/xml/System.Net.Http/ByteArrayContent.xml +++ b/xml/System.Net.Http/ByteArrayContent.xml @@ -234,7 +234,7 @@ diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 7943d5c3646..4c253657d79 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2693,7 +2693,7 @@ The is not an absolute URI. [!NOTE] > In case of timeout, different exceptions are thrown on different .NET implementations. From e34b6915e167373be663efe9fbcd4ac9ac436e21 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Thu, 3 Sep 2020 15:13:57 +0200 Subject: [PATCH 03/20] Format verification --- xml/System.Net.Http/HttpClient.xml | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 4c253657d79..3d2f97f5278 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2695,17 +2695,26 @@ The is not an absolute URI. ## Remarks This operation blocks until the entire response, including content, is read or `cancellationToken` cancels the operation. -> [!NOTE] -> In case of timeout, different exceptions are thrown on different .NET implementations. -> - is thrown on all applicable .NET Framework versions. -> - without any inner exception is thrown on all applicable .NET Core versions. -> - that nests a is thrown on .NET 5.0 and later versions. ]]> The is . + For HTTP/2 and higher or when requesting version upgrade is enabled by . + + -or- + + If using custom class derived from not overriding method. + + -or- + + If using custom not overriding method. The request message was already sent by the instance. - The request failed due to an underlying issue such as network connectivity, DNS failure, server certificate validation or timeout. - .NET Core and .NET 5.0 and later only: The request failed due to timeout. + The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + The request was canceled. + + -or- + + If the exception nests the : + The request failed due to timeout. From 9efb1cf5d72281de604edf834101890ccf9ab9b6 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Thu, 3 Sep 2020 17:00:44 +0200 Subject: [PATCH 04/20] Format verification --- xml/System.Net.Http/HttpClient.xml | 110 ++++++++++++++---- xml/System.Net.Http/HttpClientHandler.xml | 33 +++++- xml/System.Net.Http/HttpContent.xml | 64 +++++++--- xml/System.Net.Http/HttpMessageHandler.xml | 9 +- xml/System.Net.Http/HttpMessageInvoker.xml | 29 ++++- .../MessageProcessingHandler.xml | 17 ++- xml/System.Net.Http/MultipartContent.xml | 17 ++- xml/System.Net.Http/ReadOnlyMemoryContent.xml | 17 ++- xml/System.Net.Http/SocketsHttpHandler.xml | 17 ++- xml/System.Net.Http/StreamContent.xml | 17 ++- 10 files changed, 253 insertions(+), 77 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 3d2f97f5278..e9ef2615b45 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2693,7 +2693,7 @@ The is not an absolute URI. @@ -2709,11 +2709,7 @@ The is not an absolute URI. If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. - The request was canceled. - - -or- - - If the exception nests the : + If the exception nests the : The request failed due to timeout. @@ -2740,11 +2736,31 @@ The is not an absolute URI. - To be added. - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send. + When the operation should complete (as soon as a response is available or after reading the whole response content). + Send an HTTP request as a synchronous operation. + HTTP response message. + + + The is . + For HTTP/2 and higher or when requesting version upgrade is enabled by . + + -or- + + If using custom class derived from not overriding method. + + -or- + + If using custom not overriding method. + The request message was already sent by the instance. + The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + If the exception nests the : + The request failed due to timeout. @@ -2770,11 +2786,36 @@ The is not an absolute URI. - To be added. - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send. + The cancellation token to cancel operation. + Send an HTTP request as a synchronous operation. + HTTP response message. + + + + The is . + For HTTP/2 and higher or when requesting version upgrade is enabled by . + + -or- + + If using custom class derived from not overriding method. + + -or- + + If using custom not overriding method. + The request message was already sent by the instance. + The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + The request was canceled. + + -or- + + If the exception nests the : + The request failed due to timeout. @@ -2801,12 +2842,37 @@ The is not an absolute URI. - To be added. - To be added. - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send. + When the operation should complete (as soon as a response is available or after reading the whole response content). + The cancellation token to cancel operation. + Send an HTTP request as a synchronous operation. + HTTP response message. + + + + The is . + For HTTP/2 and higher or when requesting version upgrade is enabled by . + + -or- + + If using custom class derived from not overriding method. + + -or- + + If using custom not overriding method. + The request message was already sent by the instance. + The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + The request was canceled. + + -or- + + If the exception nests the : + The request failed due to timeout. diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index 1b6173d528e..e01122c32de 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -828,11 +828,34 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA - To be added. - To be added. - To be added. - To be added. - To be added. + The HTTP request message. + A cancellation token to cancel the operation. + Creates an instance of based on the information provided in the as blocking operation. + HTTP response message. + + + + The was . + For HTTP/2 and higher or when requesting version upgrade is enabled by . + + -or- + + If using custom class derived from not overriding method. + + -or- + + If using custom not overriding method. + The request was canceled. + + -or- + + If the exception nests the : + The request failed due to timeout. diff --git a/xml/System.Net.Http/HttpContent.xml b/xml/System.Net.Http/HttpContent.xml index b7f25ab9047..6992f3db97e 100644 --- a/xml/System.Net.Http/HttpContent.xml +++ b/xml/System.Net.Http/HttpContent.xml @@ -88,11 +88,19 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The target stream. + Information about the transport (channel binding token, for example). This parameter may be . + The cancellation token to cancel the operation. + Serialize the HTTP content into a stream of bytes and copies it to the stream object provided as the parameter. + + + + The was . @@ -737,9 +745,16 @@ - To be added. - To be added. - To be added. + Serialize the HTTP content and return a stream that represents the content as a synchronous operation. + The stream that represents the HTTP content. + + + @@ -764,10 +779,17 @@ - To be added. - To be added. - To be added. - To be added. + The cancellation token to cancel the operation. + Serialize the HTTP content and return a stream that represents the content as a synchronous operation. + The stream that represents the HTTP content. + + + @@ -964,11 +986,19 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The target stream. + Information about the transport (channel binding token, for example). This parameter may be . + The cancellation token to cancel the operation. + When overridden in a derived class, serializes the HTTP content to a stream as a synchronous operation. Otherwise, throws a . + + + + Any attempt is made to access the method when the method is not overridden in a descendant class. diff --git a/xml/System.Net.Http/HttpMessageHandler.xml b/xml/System.Net.Http/HttpMessageHandler.xml index 4f730e0a0e9..e9a0e359e28 100644 --- a/xml/System.Net.Http/HttpMessageHandler.xml +++ b/xml/System.Net.Http/HttpMessageHandler.xml @@ -196,11 +196,12 @@ - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send. + The cancellation token to cancel operation. + When overridden in a derived class, sends an HTTP request as a synchronous operation. Otherwise, throws a . + HTTP response message. To be added. + Any attempt is made to access the method when the method is not overridden in a descendant class. diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 90ed3048543..47efe0f1a52 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -230,11 +230,30 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send. + The cancellation token to cancel operation. + Send an HTTP request as a synchronous operation. + HTTP response message. + + or methods on the class. + + ]]> + + The was . + For HTTP/2 and higher or when requesting version upgrade is enabled by . + + -or- + + If using custom class derived from not overriding method. + + -or- + + If using custom not overriding method. diff --git a/xml/System.Net.Http/MessageProcessingHandler.xml b/xml/System.Net.Http/MessageProcessingHandler.xml index e39716b183d..07dd75e595d 100644 --- a/xml/System.Net.Http/MessageProcessingHandler.xml +++ b/xml/System.Net.Http/MessageProcessingHandler.xml @@ -226,11 +226,18 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send to the server. + A cancellation token that can be used by other objects or threads to receive notice of cancellation. + Sends an HTTP request to the inner handler to send to the server as a synchronous operation. + HTTP response message. + + + diff --git a/xml/System.Net.Http/MultipartContent.xml b/xml/System.Net.Http/MultipartContent.xml index 2aee3a22cb0..88524f57329 100644 --- a/xml/System.Net.Http/MultipartContent.xml +++ b/xml/System.Net.Http/MultipartContent.xml @@ -434,11 +434,18 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The target stream. + Information about the transport (channel binding token, for example). This parameter may be . + The cancellation token to cancel the operation. + Serialize the multipart HTTP content to a stream as a synchronous operation. + + + diff --git a/xml/System.Net.Http/ReadOnlyMemoryContent.xml b/xml/System.Net.Http/ReadOnlyMemoryContent.xml index 6741e9496ae..fb32621d0c9 100644 --- a/xml/System.Net.Http/ReadOnlyMemoryContent.xml +++ b/xml/System.Net.Http/ReadOnlyMemoryContent.xml @@ -134,11 +134,18 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The target stream. + Information about the transport (channel binding token, for example). This parameter may be . + The cancellation token to cancel the operation. + Serialize the multipart HTTP content to a stream as a synchronous operation. + + + diff --git a/xml/System.Net.Http/SocketsHttpHandler.xml b/xml/System.Net.Http/SocketsHttpHandler.xml index e9e0700fdd4..6e424d675bb 100644 --- a/xml/System.Net.Http/SocketsHttpHandler.xml +++ b/xml/System.Net.Http/SocketsHttpHandler.xml @@ -740,11 +740,20 @@ Draining occurs when a request is cancelled or a response is disposed prior to f - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send. + The cancellation token. + Sends an HTTP request as a synchronous operation. + HTTP response message. To be added. +For HTTP/2 and higher or when requesting version upgrade is enabled by . + + -or- + + If using custom class derived from not overriding method. + + -or- + + If using custom not overriding method. diff --git a/xml/System.Net.Http/StreamContent.xml b/xml/System.Net.Http/StreamContent.xml index fb2ecd95a90..d80f595019f 100644 --- a/xml/System.Net.Http/StreamContent.xml +++ b/xml/System.Net.Http/StreamContent.xml @@ -264,11 +264,18 @@ The object calls - To be added. - To be added. - To be added. - To be added. - To be added. + The target stream. + Information about the transport (channel binding token, for example). This parameter may be . + The cancellation token to cancel the operation. + Serialize the multipart HTTP content to a stream as a synchronous operation. + + + From d89511da5423a55106420a315e532f185ce762cb Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Tue, 8 Sep 2020 11:02:37 +0200 Subject: [PATCH 05/20] Fix links --- xml/System.Net.Http/HttpClient.xml | 16 ++++++++-------- xml/System.Net.Http/HttpClientHandler.xml | 4 ++-- xml/System.Net.Http/HttpMessageInvoker.xml | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index e9ef2615b45..2d7f4c8fe79 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2702,11 +2702,11 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. If the exception nests the : @@ -2752,11 +2752,11 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. If the exception nests the : @@ -2803,11 +2803,11 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. The request was canceled. @@ -2860,11 +2860,11 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. The request was canceled. diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index e01122c32de..40a72878251 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -845,11 +845,11 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request was canceled. -or- diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 47efe0f1a52..91dd9b0d3de 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -249,11 +249,11 @@ -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. From 9aad6779eae90a4d18b396cd9b6a165a509ffe2b Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Tue, 8 Sep 2020 16:01:02 +0200 Subject: [PATCH 06/20] Fix links --- xml/System.Net.Http/HttpClient.xml | 8 ++++---- xml/System.Net.Http/HttpClientHandler.xml | 2 +- xml/System.Net.Http/HttpMessageInvoker.xml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 2d7f4c8fe79..af6323b9e17 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2702,7 +2702,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- @@ -2752,7 +2752,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- @@ -2803,7 +2803,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- @@ -2860,7 +2860,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index 40a72878251..4b696ad154b 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -845,7 +845,7 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 91dd9b0d3de..01b7c8eb13c 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -249,7 +249,7 @@ -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- From 0b92a0b9602fbfd55bb058e5be4ca75ae2b9fcbe Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Tue, 8 Sep 2020 16:56:44 +0200 Subject: [PATCH 07/20] Fix xml tag --- xml/System.Net.Http/HttpClient.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index af6323b9e17..dfd9909136d 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2740,7 +2740,8 @@ The is not an absolute URI. When the operation should complete (as soon as a response is available or after reading the whole response content). Send an HTTP request as a synchronous operation. HTTP response message. - + Date: Wed, 9 Sep 2020 14:28:40 +0200 Subject: [PATCH 08/20] Fix links --- xml/System.Net.Http/HttpClient.xml | 24 +++++++++++------------ xml/System.Net.Http/HttpClientHandler.xml | 6 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index dfd9909136d..1e3776c798e 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2698,15 +2698,15 @@ The is not an absolute URI. ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + For HTTP/2 and higher or when requesting version upgrade is enabled by . -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. If the exception nests the : @@ -2749,15 +2749,15 @@ The is not an absolute URI. ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + For HTTP/2 and higher or when requesting version upgrade is enabled by . -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. If the exception nests the : @@ -2800,15 +2800,15 @@ The is not an absolute URI. ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + For HTTP/2 and higher or when requesting version upgrade is enabled by . -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. The request was canceled. @@ -2857,15 +2857,15 @@ The is not an absolute URI. ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + For HTTP/2 and higher or when requesting version upgrade is enabled by . -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. The request was canceled. diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index 4b696ad154b..ed12a2817a7 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -841,15 +841,15 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA ]]> The was . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + For HTTP/2 and higher or when requesting version upgrade is enabled by . -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. The request was canceled. -or- From fd0792f2b7cc4230f271ddc485ea35f0fffc1bbd Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Fri, 11 Sep 2020 16:51:41 +0200 Subject: [PATCH 09/20] Fix links --- xml/System.Net.Http/HttpClient.xml | 8 ++++---- xml/System.Net.Http/HttpClientHandler.xml | 2 +- xml/System.Net.Http/HttpContent.xml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 1e3776c798e..c772c2fb4c1 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2702,7 +2702,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- @@ -2753,7 +2753,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- @@ -2804,7 +2804,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- @@ -2861,7 +2861,7 @@ The is not an absolute URI. -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index ed12a2817a7..d2efc0b82e5 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -845,7 +845,7 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- diff --git a/xml/System.Net.Http/HttpContent.xml b/xml/System.Net.Http/HttpContent.xml index 6992f3db97e..28c2808cad7 100644 --- a/xml/System.Net.Http/HttpContent.xml +++ b/xml/System.Net.Http/HttpContent.xml @@ -998,7 +998,7 @@ ]]> - Any attempt is made to access the method when the method is not overridden in a descendant class. + The method is not overrided in deri. From cc123b32fa5838053a5ce6a18cb2e48afacbf898 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Fri, 11 Sep 2020 17:31:59 +0200 Subject: [PATCH 10/20] Fix links --- xml/System.Net.Http/HttpClient.xml | 8 ++++---- xml/System.Net.Http/HttpClientHandler.xml | 2 +- xml/System.Net.Http/HttpMessageInvoker.xml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index c772c2fb4c1..3baa8c961a4 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2706,7 +2706,7 @@ The is not an absolute URI. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. If the exception nests the : @@ -2757,7 +2757,7 @@ The is not an absolute URI. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. If the exception nests the : @@ -2808,7 +2808,7 @@ The is not an absolute URI. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. The request was canceled. @@ -2865,7 +2865,7 @@ The is not an absolute URI. -or- - If using custom not overriding method. + If using custom not overriding method. The request message was already sent by the instance. The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. The request was canceled. diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index d2efc0b82e5..dd17583ad18 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -849,7 +849,7 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA -or- - If using custom not overriding method. + If using custom not overriding method. The request was canceled. -or- diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 01b7c8eb13c..2bf962425b4 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -249,7 +249,7 @@ -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- From 312f0f67eab35ef873e6c2282b424a89c96971e5 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Fri, 11 Sep 2020 16:59:36 +0200 Subject: [PATCH 11/20] Apply suggestions from code review Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> --- xml/System.Net.Http/HttpMessageInvoker.xml | 2 +- xml/System.Net.Http/SocketsHttpHandler.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 2bf962425b4..67cc0a932f8 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -245,7 +245,7 @@ ]]> The was . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + For HTTP/2 and higher or when requesting version upgrade is enabled by . -or- diff --git a/xml/System.Net.Http/SocketsHttpHandler.xml b/xml/System.Net.Http/SocketsHttpHandler.xml index 6e424d675bb..0b6007d96e9 100644 --- a/xml/System.Net.Http/SocketsHttpHandler.xml +++ b/xml/System.Net.Http/SocketsHttpHandler.xml @@ -745,7 +745,7 @@ Draining occurs when a request is cancelled or a response is disposed prior to f Sends an HTTP request as a synchronous operation. HTTP response message. To be added. -For HTTP/2 and higher or when requesting version upgrade is enabled by . +For HTTP/2 and higher or when requesting version upgrade is enabled by . -or- From 8cb69c4f3842689a9f5fdd8df4f3154c6d2ea2fa Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Mon, 14 Sep 2020 11:22:24 +0200 Subject: [PATCH 12/20] Fix links --- xml/System.Net.Http/HttpMessageInvoker.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 67cc0a932f8..2406265fc65 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -249,11 +249,11 @@ -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. From e3b69dd5fd7544e41c88d3a86bdb7bd720a86c6a Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Mon, 14 Sep 2020 13:27:30 +0200 Subject: [PATCH 13/20] Add CreateContentReadStream --- xml/System.Net.Http/ByteArrayContent.xml | 15 +++++++++++---- xml/System.Net.Http/MultipartContent.xml | 17 +++++++++++++---- xml/System.Net.Http/StreamContent.xml | 17 +++++++++++++---- 3 files changed, 37 insertions(+), 12 deletions(-) diff --git a/xml/System.Net.Http/ByteArrayContent.xml b/xml/System.Net.Http/ByteArrayContent.xml index 19a3f50fab0..88cae5a5113 100644 --- a/xml/System.Net.Http/ByteArrayContent.xml +++ b/xml/System.Net.Http/ByteArrayContent.xml @@ -156,10 +156,17 @@ - To be added. - To be added. - To be added. - To be added. + The cancellation token to cancel the operation. + Creates an HTTP content stream as a synchronous operation for reading whose backing store is memory from the . + The HTTP content stream. + + + diff --git a/xml/System.Net.Http/MultipartContent.xml b/xml/System.Net.Http/MultipartContent.xml index 88524f57329..a883cbde691 100644 --- a/xml/System.Net.Http/MultipartContent.xml +++ b/xml/System.Net.Http/MultipartContent.xml @@ -212,10 +212,19 @@ - To be added. - To be added. - To be added. - To be added. + The cancellation token to cancel the operation. + Serializes the HTTP content to a stream using the multipart/* encoding as a synchronous operation. + The HTTP content stream that represents the multipart/* encoded HTTP content. + + to use a custom stream that contains an array, with each HTTP content and its boundary encoded and serialized to a instance. + + This operation is blocking untill all of the content has been written to the memory stream. + + ]]> + diff --git a/xml/System.Net.Http/StreamContent.xml b/xml/System.Net.Http/StreamContent.xml index d80f595019f..48b6119d7d4 100644 --- a/xml/System.Net.Http/StreamContent.xml +++ b/xml/System.Net.Http/StreamContent.xml @@ -149,10 +149,19 @@ The object calls - To be added. - To be added. - To be added. - To be added. + The cancellation token to cancel the operation. + Write the HTTP stream content to a memory stream as a synchronous operation. + The HTTP content stream. + + method buffers the content to a memory stream. Derived classes can override this behavior if there is a better way to retrieve the content as stream. For example, a byte array or a string could use a more efficient method way such as wrapping a read-only around the bytes or string.) + + ]]> + From 699d46546c8b6bc898c126530055962d57d3bb4f Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Mon, 14 Sep 2020 13:30:04 +0200 Subject: [PATCH 14/20] Fix links --- xml/System.Net.Http/HttpMessageInvoker.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 2406265fc65..11ed6c611a8 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -249,11 +249,11 @@ -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- - If using custom not overriding method. + If using custom not overriding method. From 4188305ec044bf1abc18ca4d3fa15d9dd8c4889c Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Mon, 14 Sep 2020 13:37:40 +0200 Subject: [PATCH 15/20] Add System.Net.Http.DelegatingHandler.Send --- xml/System.Net.Http/DelegatingHandler.xml | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/xml/System.Net.Http/DelegatingHandler.xml b/xml/System.Net.Http/DelegatingHandler.xml index df6a7a407a5..6e5443935ce 100644 --- a/xml/System.Net.Http/DelegatingHandler.xml +++ b/xml/System.Net.Http/DelegatingHandler.xml @@ -221,11 +221,20 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The HTTP request message to send to the server. + A cancellation token to cancel operation. + Sends an HTTP request to the inner handler to send to the server as a synchronous operation. + HTTP response message. + + method forwards the HTTP request to the inner handler to send to the server as a synchronous operation. + + The method is mainly used by the system and not by applications. When this method is called, it calls the method on the inner handler. + + ]]> + From 367674f1f03ff088723e882c60c9ce1202a4f0cc Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Mon, 14 Sep 2020 15:01:51 +0200 Subject: [PATCH 16/20] Fix links --- xml/System.Net.Http/HttpMessageInvoker.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 11ed6c611a8..799ea8f4cba 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -249,7 +249,7 @@ -or- - If using custom class derived from not overriding method. + If using custom class derived from not overriding method. -or- From 7d653510aeecc5072969d18972ffe9ec1253b635 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Mon, 21 Sep 2020 16:17:17 +0200 Subject: [PATCH 17/20] Apply suggestions from code review Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> --- xml/System.Net.Http/ByteArrayContent.xml | 6 +++--- xml/System.Net.Http/DelegatingHandler.xml | 6 +++--- xml/System.Net.Http/HttpClient.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xml/System.Net.Http/ByteArrayContent.xml b/xml/System.Net.Http/ByteArrayContent.xml index 88cae5a5113..683e23522d5 100644 --- a/xml/System.Net.Http/ByteArrayContent.xml +++ b/xml/System.Net.Http/ByteArrayContent.xml @@ -157,7 +157,7 @@ The cancellation token to cancel the operation. - Creates an HTTP content stream as a synchronous operation for reading whose backing store is memory from the . + Creates an HTTP content stream for reading. It uses the memory from the as a backing store. The HTTP content stream. The target stream. - Information about the transport, like channel binding token. This parameter may be . + Optional information about the transport, like the channel binding token. This parameter can be . The cancellation token to cancel the operation. - Serialize and write the byte array provided in the constructor to an HTTP content stream as a synchronous operation. + Serializes and writes the byte array provided in the constructor to an HTTP content stream. The HTTP request message to send to the server. A cancellation token to cancel operation. - Sends an HTTP request to the inner handler to send to the server as a synchronous operation. - HTTP response message. + Sends an HTTP request to the inner handler to send to the server. + An HTTP response message. method forwards the HTTP request to the inner handler to send to the server as a synchronous operation. + This operation blocks until the entire response, including content, is read. The method is mainly used by the system and not by applications. When this method is called, it calls the method on the inner handler. diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 3baa8c961a4..14a6ae3dff7 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2687,8 +2687,8 @@ The is not an absolute URI. The HTTP request message to send. - Send an HTTP request as a synchronous operation. - HTTP response message. + Send an HTTP request. + An HTTP response message. Date: Mon, 21 Sep 2020 16:19:22 +0200 Subject: [PATCH 18/20] Remove "Synchronous" information from summary --- xml/System.Net.Http/HttpClient.xml | 6 +++--- xml/System.Net.Http/HttpContent.xml | 6 +++--- xml/System.Net.Http/HttpMessageHandler.xml | 2 +- xml/System.Net.Http/HttpMessageInvoker.xml | 2 +- xml/System.Net.Http/MessageProcessingHandler.xml | 2 +- xml/System.Net.Http/MultipartContent.xml | 4 ++-- xml/System.Net.Http/ReadOnlyMemoryContent.xml | 2 +- xml/System.Net.Http/SocketsHttpHandler.xml | 2 +- xml/System.Net.Http/StreamContent.xml | 4 ++-- 9 files changed, 15 insertions(+), 15 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index 14a6ae3dff7..a9002ff92dd 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2738,7 +2738,7 @@ The is not an absolute URI. The HTTP request message to send. When the operation should complete (as soon as a response is available or after reading the whole response content). - Send an HTTP request as a synchronous operation. + Send an HTTP request. HTTP response message. is not an absolute URI. The HTTP request message to send. The cancellation token to cancel operation. - Send an HTTP request as a synchronous operation. + Send an HTTP request. HTTP response message. is not an absolute URI. The HTTP request message to send. When the operation should complete (as soon as a response is available or after reading the whole response content). The cancellation token to cancel operation. - Send an HTTP request as a synchronous operation. + Send an HTTP request. HTTP response message. - Serialize the HTTP content and return a stream that represents the content as a synchronous operation. + Serialize the HTTP content and return a stream that represents the content. The stream that represents the HTTP content. The cancellation token to cancel the operation. - Serialize the HTTP content and return a stream that represents the content as a synchronous operation. + Serialize the HTTP content and return a stream that represents the content. The stream that represents the HTTP content. The target stream. Information about the transport (channel binding token, for example). This parameter may be . The cancellation token to cancel the operation. - When overridden in a derived class, serializes the HTTP content to a stream as a synchronous operation. Otherwise, throws a . + When overridden in a derived class, serializes the HTTP content to a stream. Otherwise, throws a . The HTTP request message to send. The cancellation token to cancel operation. - When overridden in a derived class, sends an HTTP request as a synchronous operation. Otherwise, throws a . + When overridden in a derived class, sends an HTTP request. Otherwise, throws a . HTTP response message. To be added. Any attempt is made to access the method when the method is not overridden in a descendant class. diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index 799ea8f4cba..cae2b694bce 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -232,7 +232,7 @@ The HTTP request message to send. The cancellation token to cancel operation. - Send an HTTP request as a synchronous operation. + Send an HTTP request. HTTP response message. The HTTP request message to send to the server. A cancellation token that can be used by other objects or threads to receive notice of cancellation. - Sends an HTTP request to the inner handler to send to the server as a synchronous operation. + Sends an HTTP request to the inner handler to send to the server. HTTP response message. The cancellation token to cancel the operation. - Serializes the HTTP content to a stream using the multipart/* encoding as a synchronous operation. + Serializes the HTTP content to a stream using the multipart/* encoding. The HTTP content stream that represents the multipart/* encoded HTTP content. The target stream. Information about the transport (channel binding token, for example). This parameter may be . The cancellation token to cancel the operation. - Serialize the multipart HTTP content to a stream as a synchronous operation. + Serialize the multipart HTTP content to a stream. The target stream. Information about the transport (channel binding token, for example). This parameter may be . The cancellation token to cancel the operation. - Serialize the multipart HTTP content to a stream as a synchronous operation. + Serialize the multipart HTTP content to a stream. The HTTP request message to send. The cancellation token. - Sends an HTTP request as a synchronous operation. + Sends an HTTP request. HTTP response message. To be added. For HTTP/2 and higher or when requesting version upgrade is enabled by . diff --git a/xml/System.Net.Http/StreamContent.xml b/xml/System.Net.Http/StreamContent.xml index 48b6119d7d4..dd4a5841695 100644 --- a/xml/System.Net.Http/StreamContent.xml +++ b/xml/System.Net.Http/StreamContent.xml @@ -150,7 +150,7 @@ The object calls The cancellation token to cancel the operation. - Write the HTTP stream content to a memory stream as a synchronous operation. + Write the HTTP stream content to a memory stream. The HTTP content stream. object calls The target stream. Information about the transport (channel binding token, for example). This parameter may be . The cancellation token to cancel the operation. - Serialize the multipart HTTP content to a stream as a synchronous operation. + Serialize the multipart HTTP content to a stream. Date: Tue, 22 Sep 2020 21:36:37 +0200 Subject: [PATCH 19/20] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> --- xml/System.Net.Http/ByteArrayContent.xml | 4 +-- xml/System.Net.Http/HttpClient.xml | 30 +++++++++---------- xml/System.Net.Http/HttpClientHandler.xml | 4 +-- xml/System.Net.Http/HttpContent.xml | 20 ++++++------- xml/System.Net.Http/HttpMessageHandler.xml | 6 ++-- xml/System.Net.Http/HttpMessageInvoker.xml | 6 ++-- .../MessageProcessingHandler.xml | 4 +-- xml/System.Net.Http/MultipartContent.xml | 8 ++--- xml/System.Net.Http/ReadOnlyMemoryContent.xml | 6 ++-- xml/System.Net.Http/SocketsHttpHandler.xml | 2 +- xml/System.Net.Http/StreamContent.xml | 12 ++++---- 11 files changed, 51 insertions(+), 51 deletions(-) diff --git a/xml/System.Net.Http/ByteArrayContent.xml b/xml/System.Net.Http/ByteArrayContent.xml index 683e23522d5..816dc8a58d6 100644 --- a/xml/System.Net.Http/ByteArrayContent.xml +++ b/xml/System.Net.Http/ByteArrayContent.xml @@ -163,7 +163,7 @@ @@ -241,7 +241,7 @@ diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index a9002ff92dd..c999fbc5d77 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2687,7 +2687,7 @@ The is not an absolute URI. The HTTP request message to send. - Send an HTTP request. + Sends an HTTP request with the specified request. An HTTP response message. is not an absolute URI. ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + The HTTP version is 2.0 or higher or the version policy is set to . -or- - If using custom class derived from not overriding method. +The custom class derived from does not override the method. -or- - If using custom not overriding method. +The custom does not override the method. The request message was already sent by the instance. - The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + The request failed due to an underlying issue, such as network connectivity, DNS failure, or server certificate validation. If the exception nests the : The request failed due to timeout. @@ -2737,9 +2737,9 @@ The is not an absolute URI. The HTTP request message to send. - When the operation should complete (as soon as a response is available or after reading the whole response content). - Send an HTTP request. - HTTP response message. + One of the enumeration values that specifies when the operation should complete (as soon as a response is available or after reading the response content). + Sends an HTTP request. + The HTTP response message. is not an absolute URI. The HTTP request message to send. - The cancellation token to cancel operation. - Send an HTTP request. - HTTP response message. + The token to cancel the operation. + Sends an HTTP request with the specified request and cancellation token. + The HTTP response message. is not an absolute URI. The HTTP request message to send. - When the operation should complete (as soon as a response is available or after reading the whole response content). - The cancellation token to cancel operation. - Send an HTTP request. - HTTP response message. + One of the enumeration values that specifies when the operation should complete (as soon as a response is available or after reading the response content). + The token to cancel the operation. + Sends an HTTP request with the specified request, completion option and cancellation token. + The HTTP response message. The HTTP request message. A cancellation token to cancel the operation. - Creates an instance of based on the information provided in the as blocking operation. - HTTP response message. + Creates an instance of based on the information provided in the . + The HTTP response message. The target stream. - Information about the transport (channel binding token, for example). This parameter may be . + Information about the transport (for example, the channel binding token). This parameter may be . The cancellation token to cancel the operation. - Serialize the HTTP content into a stream of bytes and copies it to the stream object provided as the parameter. + Serializes the HTTP content into a stream of bytes and copies it to . @@ -745,13 +745,13 @@ - Serialize the HTTP content and return a stream that represents the content. + Serializes the HTTP content and returns a stream that represents the content. The stream that represents the HTTP content. @@ -780,13 +780,13 @@ The cancellation token to cancel the operation. - Serialize the HTTP content and return a stream that represents the content. + Serializes the HTTP content and returns a stream that represents the content. The stream that represents the HTTP content. @@ -987,18 +987,18 @@ The target stream. - Information about the transport (channel binding token, for example). This parameter may be . + Information about the transport (for example, the channel binding token). This parameter may be . The cancellation token to cancel the operation. When overridden in a derived class, serializes the HTTP content to a stream. Otherwise, throws a . - The method is not overrided in deri. + The method is not overridden in the derived class. diff --git a/xml/System.Net.Http/HttpMessageHandler.xml b/xml/System.Net.Http/HttpMessageHandler.xml index c29865d104e..3f9176205a6 100644 --- a/xml/System.Net.Http/HttpMessageHandler.xml +++ b/xml/System.Net.Http/HttpMessageHandler.xml @@ -198,10 +198,10 @@ The HTTP request message to send. The cancellation token to cancel operation. - When overridden in a derived class, sends an HTTP request. Otherwise, throws a . - HTTP response message. + When overridden in a derived class, sends an HTTP request with the specified request and cancellation token. Otherwise, throws a . + The HTTP response message. To be added. - Any attempt is made to access the method when the method is not overridden in a descendant class. + The method is not overridden in the derived class. diff --git a/xml/System.Net.Http/HttpMessageInvoker.xml b/xml/System.Net.Http/HttpMessageInvoker.xml index cae2b694bce..92586fbff04 100644 --- a/xml/System.Net.Http/HttpMessageInvoker.xml +++ b/xml/System.Net.Http/HttpMessageInvoker.xml @@ -232,13 +232,13 @@ The HTTP request message to send. The cancellation token to cancel operation. - Send an HTTP request. - HTTP response message. + Sends an HTTP request with the specified request and cancellation token. + The HTTP response message. or methods on the class. diff --git a/xml/System.Net.Http/MessageProcessingHandler.xml b/xml/System.Net.Http/MessageProcessingHandler.xml index 9c58c1ae0cc..251fe4ea6fd 100644 --- a/xml/System.Net.Http/MessageProcessingHandler.xml +++ b/xml/System.Net.Http/MessageProcessingHandler.xml @@ -229,12 +229,12 @@ The HTTP request message to send to the server. A cancellation token that can be used by other objects or threads to receive notice of cancellation. Sends an HTTP request to the inner handler to send to the server. - HTTP response message. + The HTTP response message. diff --git a/xml/System.Net.Http/MultipartContent.xml b/xml/System.Net.Http/MultipartContent.xml index 3e9a8f4fb4b..2b29c753104 100644 --- a/xml/System.Net.Http/MultipartContent.xml +++ b/xml/System.Net.Http/MultipartContent.xml @@ -219,9 +219,9 @@ to use a custom stream that contains an array, with each HTTP content and its boundary encoded and serialized to a instance. +This method overrides to use a custom stream that contains an array, with each HTTP content entity and its boundary encoded and serialized to a instance. - This operation is blocking untill all of the content has been written to the memory stream. +This operation blocks until all of the content has been written to the memory stream. ]]> @@ -444,9 +444,9 @@ The target stream. - Information about the transport (channel binding token, for example). This parameter may be . + Information about the transport (for example, the channel binding token). This parameter may be . The cancellation token to cancel the operation. - Serialize the multipart HTTP content to a stream. + Serializes the multipart HTTP content to a stream. The target stream. - Information about the transport (channel binding token, for example). This parameter may be . + Information about the transport (for example, the channel binding token). This parameter may be . The cancellation token to cancel the operation. - Serialize the multipart HTTP content to a stream. + Serializes the multipart HTTP content to a stream. diff --git a/xml/System.Net.Http/SocketsHttpHandler.xml b/xml/System.Net.Http/SocketsHttpHandler.xml index 81dda483c17..3b11c0f6950 100644 --- a/xml/System.Net.Http/SocketsHttpHandler.xml +++ b/xml/System.Net.Http/SocketsHttpHandler.xml @@ -743,7 +743,7 @@ Draining occurs when a request is cancelled or a response is disposed prior to f The HTTP request message to send. The cancellation token. Sends an HTTP request. - HTTP response message. + The HTTP response message. To be added. For HTTP/2 and higher or when requesting version upgrade is enabled by . diff --git a/xml/System.Net.Http/StreamContent.xml b/xml/System.Net.Http/StreamContent.xml index dd4a5841695..c49823b033e 100644 --- a/xml/System.Net.Http/StreamContent.xml +++ b/xml/System.Net.Http/StreamContent.xml @@ -150,15 +150,15 @@ The object calls The cancellation token to cancel the operation. - Write the HTTP stream content to a memory stream. + Writes the HTTP stream content to a memory stream. The HTTP content stream. method buffers the content to a memory stream. Derived classes can override this behavior if there is a better way to retrieve the content as stream. For example, a byte array or a string could use a more efficient method way such as wrapping a read-only around the bytes or string.) + The method buffers the content to a memory stream. Derived classes can override this behavior if there's a better way to retrieve the content as stream. For example, a byte array or a string could use a more efficient mechanism, such as wrapping a read-only around the bytes or string. ]]> @@ -274,14 +274,14 @@ The object calls The target stream. - Information about the transport (channel binding token, for example). This parameter may be . + Information about the transport (for example, the channel binding token). This parameter may be . The cancellation token to cancel the operation. - Serialize the multipart HTTP content to a stream. + Serializes the multipart HTTP content to a stream. From 71a58908dbbaa5899233ce09f3e773a68819278e Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Tue, 22 Sep 2020 21:46:24 +0200 Subject: [PATCH 20/20] Fix the exception description --- xml/System.Net.Http/HttpClient.xml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/xml/System.Net.Http/HttpClient.xml b/xml/System.Net.Http/HttpClient.xml index c999fbc5d77..3262666123a 100644 --- a/xml/System.Net.Http/HttpClient.xml +++ b/xml/System.Net.Http/HttpClient.xml @@ -2708,7 +2708,7 @@ The custom class derived from does The custom does not override the method. The request message was already sent by the instance. - The request failed due to an underlying issue, such as network connectivity, DNS failure, or server certificate validation. + The request failed due to an underlying issue such as network connectivity, DNS failure, or server certificate validation. If the exception nests the : The request failed due to timeout. @@ -2749,17 +2749,17 @@ The custom does not override ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + The HTTP version is 2.0 or higher or the version policy is set to . -or- - If using custom class derived from not overriding method. + The custom class derived from does not override the method. -or- - If using custom not overriding method. +The custom does not override the method. The request message was already sent by the instance. - The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + The request failed due to an underlying issue such as network connectivity, DNS failure, or server certificate validation. If the exception nests the : The request failed due to timeout. @@ -2800,17 +2800,17 @@ The custom does not override ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + The HTTP version is 2.0 or higher or the version policy is set to . -or- - If using custom class derived from not overriding method. + The custom class derived from does not override the method. -or- - If using custom not overriding method. +The custom does not override the method. The request message was already sent by the instance. - The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + The request failed due to an underlying issue such as network connectivity, DNS failure, or server certificate validation. The request was canceled. -or- @@ -2857,17 +2857,17 @@ The custom does not override ]]> The is . - For HTTP/2 and higher or when requesting version upgrade is enabled by . + The HTTP version is 2.0 or higher or the version policy is set to . -or- - If using custom class derived from not overriding method. + The custom class derived from does not override the method. -or- - If using custom not overriding method. +The custom does not override the method. The request message was already sent by the instance. - The request failed due to an underlying issue such as network connectivity, DNS failure or server certificate validation. + The request failed due to an underlying issue such as network connectivity, DNS failure, or server certificate validation. The request was canceled. -or-