8000 Use P2Ps in VMR orchestrator for improved build performance by ViktorHofer · Pull Request #812 · dotnet/dotnet · GitHub
[go: up one dir, main page]
Skip to content

Use P2Ps in VMR orchestrator for improved build performance #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Use P2Ps in VMR orchestrator for improved build performance #812

merged 1 commit into from
May 27, 2025

Conversation

ViktorHofer
Copy link
Member
@ViktorHofer ViktorHofer commented May 27, 2025 •
edited
Loading
  • Define P2Ps to the msbuild task projects that are used by the repo-projects targets
  • Remove the test/Microsoft.DotNet.Installer.Tests/installer-tests-prereqs.proj workaround now that we can build task projects via P2Ps from repo-projects.
  • Simplify the short stack logic by inlining the logic into dotnet.proj
  • Remove the now unnecessary tools.proj file
  • Remove the incorrect use of the Microsoft.NET.Sdk in efcore.proj. Repo-projects should use the Microsoft.Build.NoTargets SDK.

@ViktorHofer ViktorHofer marked this pull request as ready for review May 27, 2025 16:28
@ViktorHofer ViktorHofer requested review from a team as code owners May 27, 2025 16:28
@ViktorHofer ViktorHofer changed the title Use P2Ps for tasks for improved build performance Use P2Ps in VMR orchestrator for improved build performance May 27, 2025
mthalman
mthalman reviewed May 27, 2025
View reviewed changes
@ViktorHofer ViktorHofer merged commit 1801a22 into main May 27, 2025
10 checks passed
@ViktorHofer ViktorHofer deleted the UseP2PsForTasks branch May 27, 2025 18:22
@mthalman mthalman mentioned this pull request May 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthalman mthalman mthalman approved these changes

@mmitche mmitche Awaiting requested review from mmitche

@NikolaMilosavljevic NikolaMilosavljevic Awaiting requested review from NikolaMilosavljevic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @mthalman
0