8000 [main] Source code updates from dotnet/winforms by dotnet-maestro[bot] · Pull Request #340 · dotnet/dotnet · GitHub
[go: up one dir, main page]

Skip to content

[main] Source code updates from dotnet/winforms #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions prereqs/git-info/winforms.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<GitCommitHash>a345d2c077aad9aad8346aef79938c26ca029857</GitCommitHash>
<OfficialBuildId>20250429.4</OfficialBuildId>
<OutputPackageVersion>10.0.0-preview.5.25229.4</OutputPackageVersion>
<GitCommitHash>9be7da7fea56e690de436d155aa917e9cd0598a2</GitCommitHash>
<OfficialBuildId>20250501.3</OfficialBuildId>
<OutputPackageVersion>10.0.0-preview.5.25251.3</OutputPackageVersion>
</PropertyGroup>
</Project>
6 changes: 3 additions & 3 deletions src/source-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,11 @@
"commitSha": "70420a1fc04cf9a1efd42570a2873fa5bdb18ccb"
},
{
"packageVersion": "10.0.0-preview.5.25229.4",
"barId": 266349,
"packageVersion": "10.0.0-preview.5.25251.3",
"barId": 266580,
"path": "winforms",
"remoteUri": "https://github.com/dotnet/winforms",
"commitSha": "a345d2c077aad9aad8346aef79938c26ca029857"
"commitSha": "9be7da7fea56e690de436d155aa917e9cd0598a2"
},
{
"packageVersion": "10.0.0-preview.5.25229.1",
Expand Dow 8000 n
26 changes: 13 additions & 13 deletions src/winforms/.github/policies/resourceManagement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ configuration:
filters:
- isOpen
- hasLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
- hasLabel:
label: ':zzz: no-recent-activity'
- noActivitySince:
Expand All @@ -30,7 +30,7 @@ configuration:
filters:
- isOpen
- hasLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
- noActivitySince:
days: 14
- isNotLabeledWith:
Expand Down Expand Up @@ -95,7 +95,7 @@ configuration:
reviewState: Changes_requested
then:
- addLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
description: Add needs author feedback label to pull requests when changes are requested
- if:
- payloadType: Pull_Request
Expand All @@ -105,30 +105,30 @@ configuration:
isAction:
action: Closed
- hasLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
then:
- removeLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
description: Remove needs author feedback label when the author responds to a pull request
- if:
- payloadType: Issue_Comment
- isActivitySender:
issueAuthor: True
- hasLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
then:
- removeLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
description: Remove needs author feedback label when the author comments on a pull request
- if:
- payloadType: Pull_Request_Review
- isActivitySender:
issueAuthor: True
- hasLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
then:
- removeLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
description: Remove needs author feedback label when the author responds to a pull request review comment
- if:
- payloadType: Pull_Request
Expand Down Expand Up @@ -237,10 +237,10 @@ configuration:
- isActivitySender:
issueAuthor: True
- hasLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
then:
- removeLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
- addLabel:
label: 'untriaged'
description: Remove needs author feedback label when the author comments on an issue and adds untriaged label
Expand Down Expand Up @@ -312,7 +312,7 @@ configuration:
- removeLabel:
label: ':mailbox_with_mail: waiting-for-testing'
- removeLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
- removeLabel:
label: ready-to-merge
- removeLabel:
Expand All @@ -329,7 +329,7 @@ configuration:
- removeLabel:
label: untriaged
- removeLabel:
label: ':mailbox_with_no_mail: waiting-author-feedback'
label: 'waiting-author-feedback'
- removeLabel:
label: ':mailbox_with_mail: waiting-for-testing'
description: Remove intermediate labels from closed issue.
Expand Down
4 changes: 2 additions & 2 deletions src/winforms/codecov.yml
6D40
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ flags: # which files to include in the reporting
- src/System.Drawing.Design/src/
- src/System.Private.Windows.Core/src/
- src/System.Private.Windows.GdiPlus/
- src/System.Windows.Forms/src/
- src/System.Windows.Forms/
- src/System.Windows.Forms.Analyzers/src/
- src/System.Windows.Forms.Analyzers.CSharp/src/
- src/System.Windows.Forms.Design/src/
Expand All @@ -39,7 +39,7 @@ flags: # which files to include in the reporting
- src/Microsoft.VisualBasic/tests/
- src/Microsoft.VisualBasic.Forms/tests/
- src/System.Drawing.Common/tests/
- src/System.Windows.Forms/tests/
- src/test/unit/System.Windows.Forms/
- src/System.Windows.Forms.Analyzers/tests/
- src/System.Windows.Forms.Analyzers.CSharp/tests/
- src/System.Windows.Forms.Design/tests/
Expand Down
15 changes: 5 additions & 10 deletions src/winforms/docs/developer-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,22 @@ The [Issue Guide](issue-guide.md) describes our approach to using GitHub issues.

## Machine Setup

Windows Forms requires the following workloads and components be selected when installing Visual Studio 2022 (17.0.0):
Windows Forms development requires the following workloads and components be selected when installing Visual Studio 2022 (17.0.0):

* Required Workloads:
* .NET Desktop Development
* Desktop development with C++
* [Required Individual Components][required-individual-components]:
* Windows 10 SDK
* C++/CLI support
* C++ CMake tools for Windows
* Required Windows Features
* 'Media Features' including 'Windows Media Player Legacy (App)' (Windows 11) or 'Windows Media Player' (Windows 10)


:warning: CMake 3.21.0 or later is required. Install CMake from the [official website][cmake-download] or via [Chocolatey][chocolatey]:
```
choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System'
```

* 'Media Features' including 'Windows Media Player Legacy (App)' (Windows 11) or 'Windows Media Player' (Windows 10)
* Useful Visual Studio extensions:
* [Editor guidelines](https://marketplace.dev.azure.com/items?itemName=PaulHarrington.EditorGuidelines), see https://github.com/dotnet/winforms/pull/4836 for more information
* [VS Color Output](https://marketplace.dev.azure.com/items?itemName=MikeWard-AnnArbor.VSColorOutput64)
* [Productivity Power Tools](https://marketplace.dev.azure.com/items?itemName=VisualStudioPlatformTeam.ProductivityPowerPack2022)

Optional: To get the latest C# features in Visual Studio or to experiment with the latest runtime when not using the `start-vs.cmd`, install the [latest SDK build](https://github.com/dotnet/dotnet/blob/main/docs/builds-table.md).

## Workflow

Expand Down
106 changes: 53 additions & 53 deletions src/winforms/eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,114 +6,114 @@ Note: if the Uri is a new place, you will need to add a subscription from that p
And you can check these with "darc get-dependencies <dash dash>target-repo "winforms"
-->
<Dependencies>
<Source Uri="https://github.com/dotnet/dotnet" Mapping="winforms" Sha="78c5fa9a48d469a19ab5a61c16c955c1f370b5be" BarId="266331" />
<Source Uri="https://github.com/dotnet/dotnet" Mapping="winforms" Sha="35ccf19f39389d127ab037709b8e9c5a1b111a20" BarId="266496" />
<ProductDependencies>
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.10.0" Version="10.0.0-preview.5.25229.109">
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.10.0" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.Platforms" Version="10.0.0-preview.5.25229.109">
<Dependency Name="Microsoft.NETCore.Platforms" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Resources.Extensions" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Resources.Extensions" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Windows.Extensions" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Windows.Extensions" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.Sdk.IL" Version="10.0.0-preview.5.25229.109">
<Dependency Name="Microsoft.NET.Sdk.IL" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.ILAsm" Version="10.0.0-preview.5.25229.109">
<Dependency Name="Microsoft.NETCore.ILAsm" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="runtime.win-x64.Microsoft.NETCore.ILAsm" Version="10.0.0-preview.5.25229.109">
<Dependency Name="runtime.win-x64.Microsoft.NETCore.ILAsm" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="runtime.win-x86.Microsoft.NETCore.ILAsm" Version="10.0.0-preview.5.25229.109">
<Dependency Name="runtime.win-x86.Microsoft.NETCore.ILAsm" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Reflection.MetadataLoadContext" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Reflection.MetadataLoadContext" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.ILDAsm" Version="10.0.0-preview.5.25229.109">
<Dependency Name="Microsoft.NETCore.ILDAsm" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Text.Encodings.Web" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Text.Encodings.Web" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Text.Json" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Text.Json" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Ref" Version="10.0.0-preview.5.25229.109">
<Dependency Name="Microsoft.NETCore.App.Ref" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="10.0.0-preview.5.25229.109">
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Runtime.Serialization.Formatters" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Runtime.Serialization.Formatters" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.Win32.SystemEvents" Version="10.0.0-preview.5.25229.109">
<Dependency Name="Microsoft.Win32.SystemEvents" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.CodeDom" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.CodeDom" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Configuration.ConfigurationManager" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Configuration.ConfigurationManager" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.Formats.Nrbf" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.Formats.Nrbf" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="System.IO.Hashing" Version="10.0.0-preview.5.25229.109">
<Dependency Name="System.IO.Hashing" Version="10.0.0-preview.5.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<!-- Arcade -->
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.25229.109">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.GenFacades" Version="10.0.0-beta.25229.109">
<Dependency Name="Microsoft.DotNet.GenFacades" Version="10.0.0-beta.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.CMake.Sdk" Version="10.0.0-beta.25229.109">
<Dependency Name="Microsoft.DotNet.CMake.Sdk" Version="10.0.0-beta.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="10.0.0-beta.25229.109">
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="10.0.0-beta.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.RemoteExecutor" Version="10.0.0-beta.25229.109">
<Dependency Name="Microsoft.DotNet.RemoteExecutor" Version="10.0.0-beta.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XUnitExtensions" Version="10.0.0-beta.25229.109">
<Dependency Name="Microsoft.DotNet.XUnitExtensions" Version="10.0.0-beta.25230.108">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
<Sha>35ccf19f39389d127ab037709b8e9c5a1b111a20</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
Loading
0