VMR signing validation should fail when no files are processed (#330)

ellahathaway · web-flow · commit 4b12d796538e · 2025-05-01T21:48:04.000Z
diff --git a/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/SigningValidation.cs b/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/SigningValidation.cs
@@ -217,6 +217,13 @@ private void RunSignCheck()
                 Log.LogError($"SignCheck failed with exit code {process.ExitCode}: {errorLogContent}");
             }
 
+            string stdoutLog = GetLogPath(_signCheckStdoutLogFileName);
+            string stdoutLogContent = File.Exists(stdoutLog) ? File.ReadAllText(stdoutLog).Trim() : string.Empty;
+            if (!string.IsNullOrWhiteSpace(stdoutLogContent) && stdoutLogContent.Contains("No files were processed"))
+            {
+                Log.LogError("SignCheck did not process any files.");
+            }
+
             Log.LogMessage(MessageImportance.High, $"SignCheck completed.");
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,13 @@ private void RunSignCheck()`
`217`	`217`	`Log.LogError($"SignCheck failed with exit code {process.ExitCode}: {errorLogContent}");`
`218`	`218`	`}`
`219`	`219`
	`220`	`+ string stdoutLog = GetLogPath(_signCheckStdoutLogFileName);`
	`221`	`+ string stdoutLogContent = File.Exists(stdoutLog) ? File.ReadAllText(stdoutLog).Trim() : string.Empty;`
	`222`	`+ if (!string.IsNullOrWhiteSpace(stdoutLogContent) && stdoutLogContent.Contains("No files were processed"))`
	`223`	`+ {`
	`224`	`+ Log.LogError("SignCheck did not process any files.");`
	`225`	`+ }`
	`226`	`+`
`220`	`227`	`Log.LogMessage(MessageImportance.High, $"SignCheck completed.");`
`221`	`228`	`}`
`222`	`229`	`}`