Fix NotFoundSetOnFormSubmit_ResponseNotStarted_SSR test and enhanced navigation timing issue #62541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Greetings human! You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! |
…ce navigation timing Co-authored-by: ilonatommy <32700855+ilonatommy@users.noreply.github.com>
NotFoundSetOnFormSubmit_ResponseNotStarted_SSR test
Copilot finished work on behalf of
ilonatommy
July 2, 2025 13:52
ilonatommy
reviewed
Jul 2, 2025
…/else logic in NotFoundSetOnFormSubmit_ResponseNotStarted_SSR test Co-authored-by: ilonatommy <32700855+ilonatommy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a timing issue in enhanced navigation where
NotFoundcalls made synchronously could reach the enhanced navigation code before proper initialization, causing undefined access errors.Changes Made
1. Test URL Correction
Fixed
NotFoundSetOnFormSubmit_ResponseNotStarted_SSRtest to use the correct URL:/post-not-found-ssr-streaming(streaming enabled)/post-not-found-ssr(streaming disabled)The test name explicitly mentions "ResponseNotStarted" which should test non-streaming scenarios where the response hasn't started streaming yet.
2. Enhanced Navigation Timing Fix
The core issue was a race condition where synchronous
NotFoundcalls could triggerperformEnhancedPageLoadbeforenavigationEnhancementCallbackswas initialized.Root Cause: When forms submit and immediately call
NotFound, the enhanced navigation code path executes before the boot function completes initialization.Solution:
navigationEnhancementCallbacksfrom direct assignment to a promise-based patternperformEnhancedPageLoadnow awaits the callbacks promise, ensuring they're available before useFixes #62540.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.