8000 Fix remaining X509Certificate2 obsolete API usages identified in code… · dotnet/aspnetcore@afe29ff · GitHub
[go: up one dir, main page]
Skip to content

Commit afe29ff

Browse files
CopilotBrennanConroy
Copilot
and
BrennanConroy
committed
Fix remaining X509Certificate2 obsolete API usages identified in code review
Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>
1 parent f9e5cb4 commit afe29ff

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

‎src/Security/Authentication/WsFederation/samples/WsFedSample/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private static X509Certificate2 LoadCertificate()
5454
certificatePayload = memoryStream.ToArray();
5555
}
5656

57-
return X509CertificateLoader.LoadPkcs12FromFile(certificatePayload, "testPassword");
57+
return X509CertificateLoader.LoadPkcs12(certificatePayload, "testPassword");
5858
}
5959
}
6060
}

‎src/Servers/Kestrel/samples/WebTransportInteractiveSampleApp/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ static X509Certificate2 GenerateManualCertificate()
192192
req.CertificateExtensions.Add(sanBuilder.Build());
193193
// Sign
194194
using var crt = req.CreateSelfSigned(now, now.AddDays(14)); // 14 days is the max duration of a certificate for this
195-
cert = new(crt.Export(X509ContentType.Pfx));
195+
cert = X509CertificateLoader.LoadPkcs12(crt.Export(X509ContentType.Pfx));
196196

197197
// Save
198198
store.Add(cert);

‎src/Servers/Kestrel/samples/WebTransportSampleApp/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ static X509Certificate2 GenerateManualCertificate()
7878
req.CertificateExtensions.Add(sanBuilder.Build());
7979
// Sign
8080
using var crt = req.CreateSelfSigned(now, now.AddDays(14)); // 14 days is the max duration of a certificate for this
81-
cert = new(crt.Export(X509ContentType.Pfx));
81+
cert = X509CertificateLoader.LoadPkcs12(crt.Export(X509ContentType.Pfx));
8282

8383
// Save
8484
store.Add(cert);

‎src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ public void EnsureCreateHttpsCertificate_CanExportTheCertInPemFormat_WithoutKey(
215215
Assert.Equal(EnsureCertificateResult.ValidCertificatePresent, result);
216216
Assert.True(File.Exists(CertificateName));
217217

218-
var exportedCertificate = X509CertificateLoader.LoadCertificate(CertificateName);
218+
var exportedCertificate = X509CertificateLoader.LoadCertificateFromFile(CertificateName);
219219
Assert.NotNull(exportedCertificate);
220220
Assert.False(exportedCertificate.HasPrivateKey);
221221
}

0 commit comments

Comments
 (0)
0