dotnet
diff --git a/‎Libraries/Docs/DocsCommentsContainer.cs
Lines changed: 11 additions & 5 deletions b/‎Libraries/Docs/DocsCommentsContainer.cs
Lines changed: 11 additions & 5 deletions
diff --git a/‎Libraries/IntelliSenseXml/IntelliSenseXmlCommentsContainer.cs
Lines changed: 15 additions & 4 deletions b/‎Libraries/IntelliSenseXml/IntelliSenseXmlCommentsContainer.cs
Lines changed: 15 additions & 4 deletions
@@ -86,7 +86,7 @@ public void Save()
                 }
                 catch (Exception e)
                 {
-                    Log.Error(e.Message);
+                    Log.Error("Failed to write to {0}. {1}", type.FilePath, e.Message);
                     Log.Line();
                     Log.Error(e.StackTrace ?? string.Empty);
                     if (e.InnerException != null)
@@ -174,12 +174,18 @@ private IEnumerable<FileInfo> EnumerateFiles()
 
         private void LoadFile(FileInfo fileInfo)
         {
-            if (!fileInfo.Exists)
+            try
             {
-                throw new Exception($"Docs xml file does not exist: {fileInfo.FullName}");
+                // docs repo uses code page 1252
+                Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
+                StreamReader sr = new(fileInfo.FullName, Encoding.GetEncoding(1252));
+                xDoc = XDocument.Load(sr);
+            }
+            catch(Exception ex)
+            {
+                Log.Error($"Failed to load '{fileInfo.FullName}'. {ex}");
+                return;
             }
-
-            xDoc = XDocument.Load(fileInfo.FullName);
 
             if (IsXmlMalformed(xDoc, fileInfo.FullName))
             {
 
@@ -4,6 +4,7 @@
 using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Linq;
+using System.Xml;
 using System.Xml.Linq;
 
 /*
@@ -85,12 +86,15 @@ private IEnumerable<FileInfo> EnumerateFiles()
 
         private void LoadFile(FileInfo fileInfo, bool printSuccess)
         {
-            if (!fileInfo.Exists)
+            try
             {
-                throw new Exception($"The IntelliSense xml file does not exist: {fileInfo.FullName}");
+                xDoc = XDocument.Load(fileInfo.FullName);
+            }
+            catch (Exception ex)
+            {
+                Log.Error($"Failed to load '{fileInfo.FullName}'. {ex}");
+                return;
             }
-
-            xDoc = XDocument.Load(fileInfo.FullName);
 
             if (TryGetAssemblyName(xDoc, fileInfo.FullName, out string? assembly))
             {
@@ -135,12 +139,19 @@ private bool TryGetAssemblyName(XDocument? xDoc, string fileName, [NotNullWhen(r
                 Log.Error($"The XDocument was null: {fileName}");
                 return true;
             }
+
             if (xDoc.Root == null)
             {
                 Log.Error($"The IntelliSense xml file does not contain a root element: {fileName}");
                 return true;
             }
 
+            if (xDoc.Root.Name == "linker" || xDoc.Root.Name == "FileList")
+            {
+                // This is a linker suppression file or a framework list
+                return true;
+            }
+
             if (xDoc.Root.Name != "doc")
             {
                 Log.Error($"The IntelliSense xml file does not contain a doc element: {fileName}");
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public void Save()`
`86`	`86`	`}`
`87`	`87`	`catch (Exception e)`
`88`	`88`	`{`
`89`		`- Log.Error(e.Message);`
	`89`	`+ Log.Error("Failed to write to {0}. {1}", type.FilePath, e.Message);`
`90`	`90`	`Log.Line();`
`91`	`91`	`Log.Error(e.StackTrace ?? string.Empty);`
`92`	`92`	`if (e.InnerException != null)`
`@@ -174,12 +174,18 @@ private IEnumerable<FileInfo> EnumerateFiles()`
`174`	`174`
`175`	`175`	`private void LoadFile(FileInfo fileInfo)`
`176`	`176`	`{`
`177`		`- if (!fileInfo.Exists)`
	`177`	`+ try`
`178`	`178`	`{`
`179`		`- throw new Exception($"Docs xml file does not exist: {fileInfo.FullName}");`
	`179`	`+ // docs repo uses code page 1252`
	`180`	`+ Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);`
	`181`	`+ StreamReader sr = new(fileInfo.FullName, Encoding.GetEncoding(1252));`
	`182`	`+ xDoc = XDocument.Load(sr);`
	`183`	`+ }`
	`184`	`+ catch(Exception ex)`
	`185`	`+ {`
	`186`	`+ Log.Error($"Failed to load '{fileInfo.FullName}'. {ex}");`
	`187`	`+ return;`
`180`	`188`	`}`
`181`		`-`
`182`		`- xDoc = XDocument.Load(fileInfo.FullName);`
`183`	`189`
`184`	`190`	`if (IsXmlMalformed(xDoc, fileInfo.FullName))`
`185`	`191`	`{`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`using System.Diagnostics.CodeAnalysis;`
`5`	`5`	`using System.IO;`
`6`	`6`	`using System.Linq;`
	`7`	`+using System.Xml;`
`7`	`8`	`using System.Xml.Linq;`
`8`	`9`
`9`	`10`	`/*`
`@@ -85,12 +86,15 @@ private IEnumerable<FileInfo> EnumerateFiles()`
`85`	`86`
`86`	`87`	`private void LoadFile(FileInfo fileInfo, bool printSuccess)`
`87`	`88`	`{`
`88`		`- if (!fileInfo.Exists)`
	`89`	`+ try`
`89`	`90`	`{`
`90`		`- throw new Exception($"The IntelliSense xml file does not exist: {fileInfo.FullName}");`
	`91`	`+ xDoc = XDocument.Load(fileInfo.FullName);`
	`92`	`+ }`
	`93`	`+ catch (Exception ex)`
	`94`	`+ {`
	`95`	`+ Log.Error($"Failed to load '{fileInfo.FullName}'. {ex}");`
	`96`	`+ return;`
`91`	`97`	`}`
`92`		`-`
`93`		`- xDoc = XDocument.Load(fileInfo.FullName);`
`94`	`98`
`95`	`99`	`if (TryGetAssemblyName(xDoc, fileInfo.FullName, out string? assembly))`
`96`	`100`	`{`
`@@ -135,12 +139,19 @@ private bool TryGetAssemblyName(XDocument? xDoc, string fileName, [NotNullWhen(r`
`135`	`139`	`Log.Error($"The XDocument was null: {fileName}");`
`136`	`140`	`return true;`
`137`	`141`	`}`
	`142`	`+`
`138`	`143`	`if (xDoc.Root == null)`
`139`	`144`	`{`
`140`	`145`	`Log.Error($"The IntelliSense xml file does not contain a root element: {fileName}");`
`141`	`146`	`return true;`
`142`	`147`	`}`
`143`	`148`
	`149`	`+ if (xDoc.Root.Name == "linker" \|\| xDoc.Root.Name == "FileList")`
	`150`	`+ {`
	`151`	`+ // This is a linker suppression file or a framework list`
	`152`	`+ return true;`
	`153`	`+ }`
	`154`	`+`
`144`	`155`	`if (xDoc.Root.Name != "doc")`
`145`	`156`	`{`
`146`	`157`	`Log.Error($"The IntelliSense xml file does not contain a doc element: {fileName}");`