8000 Bugs in torch.nn.AvgPool2d and torch.nn.AvgPool3d methods · Issue #1200 · dotnet/TorchSharp · GitHub
[go: up one dir, main page]
Skip to content
Bugs in torch.nn.AvgPool2d and torch.nn.AvgPool3d methods #1200
New issue
New issue
Closed
Closed
Bugs in torch.nn.AvgPool2d and torch.nn.AvgPool3d methods#1200
@phizch

Description

@phizch
phizch
opened on Jan 17, 2024

There are multiple bugs in the AvgPool2d and AvgPool3d construct functions on torch.nn

https://github.com/dotnet/TorchSharp/blob/a6692b759cad4d9210ac617048b9cf66fd37500b/src/TorchSharp/NN/Pooling/AvgPool2D.cs#L72C1-L73C75

                long pvalue1 = (padding == null) ? 0 : stride.Value.Item1;
                long pvalue2 = (padding == null) ? 0 : stride.Value.Item2;
// -- should be --
                long pvalue1 = (padding == null) ? 0 : padding.Value.Item1;
                long pvalue2 = (padding == null) ? 0 : padding.Value.Item2;

https://github.com/dotnet/TorchSharp/blob/a6692b759cad4d9210ac617048b9cf66fd37500b/src/TorchSharp/NN/Pooling/AvgPool3D.cs#L75C1-L77C75

                long pvalue1 = (padding == null) ? 0 : stride.Value.Item1;
                long pvalue2 = (padding == null) ? 0 : stride.Value.Item2;
                long pvalue3 = (padding == null) ? 0 : stride.Value.Item3;
// -- should be --
                long pvalue1 = (padding == null) ? 0 : padding.Value.Item1;
                long pvalue2 = (padding == null) ? 0 : padding.Value.Item2;
                long pvalue3 = (padding == null) ? 0 : padding.Value.Item3;

https://github.com/dotnet/TorchSharp/blob/a6692b759cad4d9210ac617048b9cf66fd37500b/src/TorchSharp/NN/Pooling/AvgPool3D.cs#L100C68-L100C68

                long pvalue = (stride == null) ? 0 : padding.Value;
// -- should be --
                long pvalue = (padding == null) ? 0 : padding.Value;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0