8000 mu_product in NAdam optimizer is never initialized · Issue #1154 · dotnet/TorchSharp · GitHub
[go: up one dir, main page]

Skip to content
mu_product in NAdam optimizer is never initialized #1154
Closed
@shaltielshmid

Description

@shaltielshmid

The mu_product field in the NAdam state is never initialized and therefore defaults to zero. See here the initialization of the state (I also searched the rest of the code and there was no other initialization):
image

The mu_product by definition is always going to be the product of other multiplications, and therefore will always remain 0.

In the PyTorch documentation, you can see that in the source code for NAdam in the _init_group function they initialize the mu_product to 1:

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0