10000 Activate reliability tests, they run fine · dotnet/SqlClient@ae33c5f · GitHub
[go: up one dir, main page]
Skip to content

Commit ae33c5f

Browse files
MichelZbenrr101
MichelZ
authored and
benrr101
committed
Activate reliability tests, they run fine
1 parent c97b74a commit ae33c5f

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

‎src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/SqlCommandReliabilityTest.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ public void RetryExecuteCancel(string cnnString, SqlRetryLogicBaseProvider provi
135135
}
136136
}
137137

138-
[ActiveIssue("14588")]
139138
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
140139
[MemberData(nameof(RetryLogicTestHelper.GetConnectionAndRetryStrategyInvalidCommand), parameters: new object[] { 5 }, MemberType = typeof(RetryLogicTestHelper), DisableDiscoveryEnumeration = true)]
141140
public void RetryExecuteWithTransScope(string cnnString, SqlRetryLogicBaseProvider provider)
@@ -261,7 +260,6 @@ public void RetryExecuteUnauthorizedSqlStatementDML(string cnnString, SqlRetryLo
261260
}
262261
}
263262

264-
[ActiveIssue("14325")]
265263
// avoid creating a new database in Azure
266264
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureServer), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
267265
[MemberData(nameof(RetryLogicTestHelper.GetConnectionAndRetryStrategyDropDB), parameters: new object[] { 5 }, MemberType = typeof(RetryLogicTestHelper), DisableDiscoveryEnumeration = true)]
@@ -283,7 +281,7 @@ public void DropDatabaseWithActiveConnection(string cnnString, SqlRetryLogicBase
283281
cnn1.Open();
284282
cmd.Connection = cnn1;
285283
// Create the database and wait until it is finalized.
286-
cmd.CommandText = $"CREATE DATABASE [{database}]; \nWHILE(NOT EXISTS(SELECT 1 FROM sys.databases WHERE name = '{database}')) \nWAITFOR DELAY '00:00:10' ";
284+
cmd.CommandText = $"CREATE DATABASE [{database}]; \nWHILE(NOT EXISTS(SELECT 1 FROM sys.databases WHERE name = '{database}')) \nWAITFOR DELAY '00:00:01' ";
287285
cmd.ExecuteNonQuery();
288286

289287
try
@@ -292,7 +290,7 @@ public void DropDatabaseWithActiveConnection(string cnnString, SqlRetryLogicBase
292290
cnn2.Open();
293291
cnn3.Open();
294292

295-
// kill the active connection to the database after the first faliure.
293+
// kill the active connection to the database after the first failure.
296294
provider.Retrying += (s, e) =>
297295
{
298296
currentRetries = e.RetryCount;

‎src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/SqlConnectionReliabilityTest.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ public void ConnectionCancelRetryOpenInvalidCatalog(string cnnString, SqlRetryLo
5151
}
5252
}
5353

54-
[ActiveIssue("14590", TestPlatforms.Windows)]
5554
// avoid creating a new database in Azure
5655
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureServer), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
5756
[MemberData(nameof(RetryLogicTestHelper.GetConnectionAndRetryStrategyLongRunner), parameters: new object[] { 10 }, MemberType = typeof(RetryLogicTestHelper), DisableDiscoveryEnumeration = true)]
@@ -76,7 +75,7 @@ public void CreateDatabaseWhileTryingToConnect(string cnnString, SqlRetryLogicBa
7675
provider.Retrying += (s, e) =>
7776
{
7877
currentRetries = e.RetryCount;
79-
// Try to create database just after first faliure.
78+
// Try to create database just after first failure.
8079
if (createDBTask == null || createDBTask.Status == TaskStatus.Faulted)
8180
{
8281
cmd.CommandText = $"IF (NOT EXISTS(SELECT 1 FROM sys.databases WHERE name = '{database}')) CREATE DATABASE [{database}];";
@@ -100,7 +99,6 @@ public void CreateDatabaseWhileTryingToConnect(string cnnString, SqlRetryLogicBa
10099
Assert.True(currentRetries > 0);
101100
}
102101

103-
[ActiveIssue("25147")]
104102
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
105103
[MemberData(nameof(RetryLogicTestHelper.GetConnectionAndRetryStrategyInvalidCatalog), parameters: new object[] { 2 }, MemberType = typeof(RetryLogicTestHelper), DisableDiscoveryEnumeration = true)]
106104
public void ConcurrentExecution(string cnnString, SqlRetryLogicBaseProvider provider)

0 commit comments

Comments
 (0)
0