8000 Activate CommandCancel tests, add Conditions to existing issue · dotnet/SqlClient@68b7e1a · GitHub
[go: up one dir, main page]

Skip to content

Commit 68b7e1a

Browse files
MichelZbenrr101
authored andcommitted
Activate CommandCancel tests, add Conditions to existing issue
1 parent 6fcd405 commit 68b7e1a

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlCommand/SqlCommandCancelTest.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ public static void TimeoutCancel()
157157
TimeoutCancel(tcp_connStr);
158158
}
159159

160-
[ActiveIssue("12167")]
160+
[ActiveIssue("12167", typeof(DataTestUtility), nameof(DataTestUtility.UseManagedSNIOnWindows))] // Managed SNI does not seem to work here
161161
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
162162
[PlatformSpecific(TestPlatforms.Windows)]
163163
public static void TimeoutCancelNP()
@@ -178,15 +178,13 @@ public static void CancelAndDisposePreparedCommandNP()
178178
CancelAndDisposePreparedCommand(np_connStr);
179179
}
180180

181-
[ActiveIssue("5541")]
182-
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
181+
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer), nameof(DataTestUtility.IsNotNamedInstance))]
183182
public static void TimeOutDuringRead()
184183
{
185184
TimeOutDuringRead(tcp_connStr);
186185
}
187186

188-
[ActiveIssue("5541")]
189-
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
187+
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer), nameof(DataTestUtility.IsNotNamedInstance))]
190188
[PlatformSpecific(TestPlatforms.Windows)]
191189
public static void TimeOutDuringReadNP()
192190
{
@@ -357,7 +355,8 @@ private static void TimeoutCancel(string constr)
357355
cmd.CommandText = "WAITFOR DELAY '00:00:20';select * from Customers";
358356

359357
string errorMessage = SystemDataResourceManager.Instance.SQL_Timeout_Execution;
360-
DataTestUtility.ExpectFailure<SqlException>(() => ExecuteReaderOnCmd(cmd), new string[] { errorMessage });
358+
var ex = Assert.Throws<SqlException>(() => ExecuteReaderOnCmd(cmd));
359+
Assert.Equal(errorMessage, ex.Message);
361360

362361
VerifyConnection(cmd);
363362
}

0 commit comments

Comments
 (0)
0