Support custom awaitable types #2349
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force async unroll factor to 1. Support async IterationSetup/IterationCleanup.
# Conflicts: # tests/BenchmarkDotNet.IntegrationTests/InProcessTest.cs
…ead-new # Conflicts: # tests/BenchmarkDotNet.IntegrationTests/InProcessTest.cs
# Conflicts: # src/BenchmarkDotNet/Engines/IEngine.cs # src/BenchmarkDotNet/Toolchains/InProcess.Emit.Implementation/ConsumableTypeInfo.cs # src/BenchmarkDotNet/Toolchains/InProcess.Emit.Implementation/Emitters/RunnableEmitter.cs
# Conflicts: # src/BenchmarkDotNet/Toolchains/InProcess/BenchmarkAction.cs # src/BenchmarkDotNet/Toolchains/InProcess/BenchmarkActionFactory.cs # src/BenchmarkDotNet/Toolchains/InProcess/BenchmarkActionFactory_Implementations.cs # src/BenchmarkDotNet/Toolchains/InProcess/Emit/Implementation/Emitters/TaskConsumeEmitter.cs # src/BenchmarkDotNet/Toolchains/InProcess/InProcessRunner.cs # tests/BenchmarkDotNet.IntegrationTests/InProcessTest.cs
Use async consumers in toolchains (WIP).
Handle overhead without duplicating the state machine code.
Split AsyncBenchmarkRunner workload and overhead.
Use abstract base class without generics. Explicitly specify overhead awaitable/awaiter types. Use awaitable types in InProcessNoEmitToolchain.
Support multiple generic arguments in adapters. No need to pass awaitable type to config, only pass awaitable adapter type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype for supporting any type of awaitable, stemmed from the discussion in #2111. (It might even be able to supersede that PR, since I am seeing even better
Taskbenchmark results).New interfaces are used for BDN to know how to make a type awaitable.
An adapter type is added to the config to make the benchmark await it, along with an optional async method builder adapter (more on that below).
Example
And the results:
Woah, we can actually measure the cost of
await Task.Yield()now, which was previously impossible!IAsyncMethodBuilderAdapteris an optional adapter type used to override the defaultAsyncTaskMethodBuilder, because some builders use more efficient await strategies for known awaiter types. For example, I measured ~100ns slowdown withPromisewhen using the defaultAsyncTaskMethodBuilderinstead of using the customPromiseMethodBuilder.Currently in this prototype, I only supported custom awaits with the config, no attribute support. If we want attribute support, I'm not sure how it should look like. Also, I haven't updated the
InProcessEmitToolchainwith this system yet, because I want some feedback first.Also, I did test this with the
InProcessNoEmitToolchainwith NativeAOT, and it worked flawlessly.cc @YegorStepanov