8000 [RFC]: Replace Controllers with Handlers · Issue #27 · dotkernel/light · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Replace Controllers with Handlers #27

Closed
arhimede opened this issue Feb 4, 2025 · 3 comments
Closed

[RFC]: Replace Controllers with Handlers #27

arhimede opened this issue Feb 4, 2025 · 3 comments
Assignees
@alexmerlin @MarioRadu
Labels
enhancement New feature or request

Comments

@arhimede
Copy link
Member
arhimede commented Feb 4, 2025

RFC

Q A
Proposed Version(s) 1.2.0
BC Break? Yes

Goal

proof of concept
use Handlers instead of Controllers
to use better the middleware pipes
See this comment of @Xerkus dotkernel/api#313 (comment)
@arhimede arhimede added this to Backlog Feb 4, 2025
@alexmerlin alexmerlin mentioned this issue Feb 7, 2025
Merged
@alexmerlin alexmerlin added the enhancement New feature or request label Feb 7, 2025
@arhimede
Copy link
Member Author

Which is the best approache ?

A. method in filename:
Page/Handler/GetAboutUsHandler.php
Page/Handler/PostAboutUsHandler.php

B. all methods in one handler in filename:
Page/Handler/AboutUsHandler.php

@arhimede
Copy link
Member Author

@MarioRadu
Keep the PAGE module then
without switch

@alexmerlin
Copy link
Member

Implemented in #33

@github-project-automation github-project-automation bot moved this to Done in Backlog Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmerlin alexmerlin

@MarioRadu MarioRadu

Labels
enhancement New feature or request
Projects
Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexmerlin @MarioRadu @arhimede
0