Managed subtransport: support Default Credentials

ethomson · ethomson · commit a5ef816147ad · 2020-05-10T22:50:47.000+01:00
diff --git a/LibGit2Sharp/Core/ManagedHttpSmartSubtransport.cs b/LibGit2Sharp/Core/ManagedHttpSmartSubtransport.cs
@@ -199,8 +199,16 @@ private HttpResponseMessage GetResponseWithRedirects()
                                 throw new InvalidOperationException("authentication cancelled");
                             }
 
-                            UsernamePasswordCredentials userpass = (UsernamePasswordCredentials)cred;
-                            credentials = new NetworkCredential(userpass.Username, userpass.Password);
+                            if (cred is DefaultCredentials)
+                            {
+                                credentials = CredentialCache.DefaultNetworkCredentials;
+                            }
+                            else if (cred is UsernamePasswordCredentials)
+                            {
+                                UsernamePasswordCredentials userpass = (UsernamePasswordCredentials)cred;
+                                credentials = new NetworkCredential(userpass.Username, userpass.Password);
+                            }
+
                             continue;
                         }
                         else if (response.StatusCode == HttpStatusCode.Moved || response.StatusCode == HttpStatusCode.Redirect)
diff --git a/LibGit2Sharp/SmartSubtransport.cs b/LibGit2Sharp/SmartSubtransport.cs
@@ -106,6 +106,10 @@ public int AcquireCredentials(out Credentials cred, string user, params Type[] m
                 {
                     allowed |= (int)GitCredentialType.UserPassPlaintext;
                 }
+                else if (method == typeof(DefaultCredentials))
+                {
+                    allowed |= (int)GitCredentialType.Default;
+                }
                 else
                 {
                     throw new InvalidOperationException("Unknown type passes as allowed credential");
@@ -133,6 +137,9 @@ public int AcquireCredentials(out Credentials cred, string user, params Type[] m
                     case GitCredentialType.UserPassPlaintext:
                         cred = UsernamePasswordCredentials.FromNative((GitCredentialUserpass*) credHandle);
                         return 0;
+                    case GitCredentialType.Default:
+                        cred = new DefaultCredentials();
+                        return 0;
                     default:
                         throw new InvalidOperationException("User returned an unkown credential type");
                 }

Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,10 @@ public int AcquireCredentials(out Credentials cred, string user, params Type[] m`
`106`	`106`	`{`
`107`	`107`	`allowed \|= (int)GitCredentialType.UserPassPlaintext;`
`108`	`108`	`}`
	`109`	`+ else if (method == typeof(DefaultCredentials))`
	`110`	`+ {`
	`111`	`+ allowed \|= (int)GitCredentialType.Default;`
	`112`	`+ }`
`109`	`113`	`else`
`110`	`114`	`{`
`111`	`115`	`throw new InvalidOperationException("Unknown type passes as allowed credential");`
`@@ -133,6 +137,9 @@ public int AcquireCredentials(out Credentials cred, string user, params Type[] m`
`133`	`137`	`case GitCredentialType.UserPassPlaintext:`
`134`	`138`	`cred = UsernamePasswordCredentials.FromNative((GitCredentialUserpass*) credHandle);`
`135`	`139`	`return 0;`
	`140`	`+ case GitCredentialType.Default:`
	`141`	`+ cred = new DefaultCredentials();`
	`142`	`+ return 0;`
`136`	`143`	`default:`
`137`	`144`	`throw new InvalidOperationException("User returned an unkown credential type");`
`138`	`145`	`}`