Always use managed https transport

bording · bording · commit 868eb38791ee · 2020-11-07T12:09:10.000-05:00
diff --git a/LibGit2Sharp/Core/NativeMethods.cs b/LibGit2Sharp/Core/NativeMethods.cs
@@ -197,7 +197,7 @@ private static void InitializeNativeLibrary()
             }
 
             // Configure the .NET HTTP(S) mechanism on the first initialization of the library in the current process.
-            if (initCounter == 1 && GlobalSettings.ManagedHttpSmartSubtransportEnabled)
+            if (initCounter == 1)
             {
                 httpSubtransportRegistration = GlobalSettings.RegisterDefaultSmartSubtransport<ManagedHttpSmartSubtransport>("http");
                 httpsSubtransportRegistration = GlobalSettings.RegisterDefaultSmartSubtransport<ManagedHttpSmartSubtransport>("https");
diff --git a/LibGit2Sharp/GlobalSettings.cs b/LibGit2Sharp/GlobalSettings.cs
@@ -22,8 +22,6 @@ public static class GlobalSettings
         private static bool nativeLibraryPathLocked;
         private static string nativeLibraryDefaultPath;
 
-        private static bool useManagedHttpSmartSubtransport = true;
-
         internal class SmartSubtransportData
         {
             internal bool isCustom;
@@ -83,8 +81,6 @@ private static string GetExecutingAssemblyDirectory()
         /// </summary>
         public static Version Version => version.Value;
 
-        internal static bool ManagedHttpSmartSubtransportEnabled => RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || useManagedHttpSmartSubtransport;
-
         private static SmartSubtransportData GetOrCreateSmartSubtransportData(string scheme)
         {
             Ensure.ArgumentNotNull(scheme, "scheme");
@@ -539,13 +535,5 @@ public static string GetUserAgent()
         {
             return Proxy.git_libgit2_opts_get_user_agent();
         }
-
-        /// <summary>
-        /// Enables the native http implementation. This can only be enabled on Windows or macOS.
-        /// </summary>
-        public static void UseNativeHttpTransport()
-        {
-            useManagedHttpSmartSubtransport = false;
-        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ private static void InitializeNativeLibrary()`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`// Configure the .NET HTTP(S) mechanism on the first initialization of the library in the current process.`
`200`		`- if (initCounter == 1 && GlobalSettings.ManagedHttpSmartSubtransportEnabled)`
	`200`	`+ if (initCounter == 1)`
`201`	`201`	`{`
`202`	`202`	`httpSubtransportRegistration = GlobalSettings.RegisterDefaultSmartSubtransport<ManagedHttpSmartSubtransport>("http");`
`203`	`203`	`httpsSubtransportRegistration = GlobalSettings.RegisterDefaultSmartSubtransport<ManagedHttpSmartSubtransport>("https");`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,6 @@ public static class GlobalSettings`
`22`	`22`	`private static bool nativeLibraryPathLocked;`
`23`	`23`	`private static string nativeLibraryDefaultPath;`
`24`	`24`
`25`		`- private static bool useManagedHttpSmartSubtransport = true;`
`26`		`-`
`27`	`25`	`internal class SmartSubtransportData`
`28`	`26`	`{`
`29`	`27`	`internal bool isCustom;`
`@@ -83,8 +81,6 @@ private static string GetExecutingAssemblyDirectory()`
`83`	`81`	`/// </summary>`
`84`	`82`	`public static Version Version => version.Value;`
`85`	`83`
`86`		`- internal static bool ManagedHttpSmartSubtransportEnabled => RuntimeInformation.IsOSPlatform(OSPlatform.Linux) \|\| useManagedHttpSmartSubtransport;`
`87`		`-`
`88`	`84`	`private static SmartSubtransportData GetOrCreateSmartSubtransportData(string scheme)`
`89`	`85`	`{`
`90`	`86`	`Ensure.ArgumentNotNull(scheme, "scheme");`
`@@ -539,13 +535,5 @@ public static string GetUserAgent()`
`539`	`535`	`{`
`540`	`536`	`return Proxy.git_libgit2_opts_get_user_agent();`
`541`	`537`	`}`
`542`		`-`
`543`		`- /// <summary>`
`544`		`- /// Enables the native http implementation. This can only be enabled on Windows or macOS.`
`545`		`- /// </summary>`
`546`		`- public static void UseNativeHttpTransport()`
`547`		`- {`
`548`		`- useManagedHttpSmartSubtransport = false;`
`549`		`- }`
`550`	`538`	`}`
`551`	`539`	`}`