fix: [array-type] revert unnecessary changes

armano2 · armano2 · commit b67e62682f93 · 2021-11-19T21:04:24.000+01:00
diff --git a/packages/eslint-plugin/src/rules/array-type.ts b/packages/eslint-plugin/src/rules/array-type.ts
@@ -182,9 +182,9 @@ export default util.createRule<Options, MessageIds>({
             type: getMessageType(node.elementType),
           },
           fix(fixer) {
+            const typeNode = node.elementType;
             const arrayType = isReadonly ? 'ReadonlyArray' : 'Array';
 
-            const typeNode = node.elementType;
             return [
               fixer.replaceTextRange(
                 [errorNode.range[0], typeNode.range[0]],
diff --git a/packages/eslint-plugin/tests/rules/array-type.test.ts b/packages/eslint-plugin/tests/rules/array-type.test.ts
@@ -1230,7 +1230,7 @@ function barFunction(bar: Array<ArrayClass<String>>) {
       errors: [
         {
           messageId: 'errorStringArraySimple',
-          data: { type: 'fooName.BarType', array: 'Array' },
+          data: { type: 'fooName.BarType' },
           line: 1,
           column: 8,
         },

Original file line number	Diff line number	Diff line change
`@@ -1230,7 +1230,7 @@ function barFunction(bar: Array<ArrayClass<String>>) {`
`1230`	`1230`	`errors: [`
`1231`	`1231`	`{`
`1232`	`1232`	`messageId: 'errorStringArraySimple',`
`1233`		`- data: { type: 'fooName.BarType', array: 'Array' },`
	`1233`	`+ data: { type: 'fooName.BarType' },`
`1234`	`1234`	`line: 1,`
`1235`	`1235`	`column: 8,`
`1236`	`1236`	`},`