fix(eslint-plugin): [prefer-literal-enum-member] allow pure template literal strings (typescript-eslint#2786)

ddubrava · web-flow · commit f3bf6a1791c9 · 2020-11-19T12:19:14.000-08:00
diff --git a/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts b/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts
@@ -29,6 +29,13 @@ export default createRule({
         if (node.initializer.type === AST_NODE_TYPES.Literal) {
           return;
         }
+        // TemplateLiteral without expressions
+        if (
+          node.initializer.type === AST_NODE_TYPES.TemplateLiteral &&
+          node.initializer.expressions.length === 0
+        ) {
+          return;
+        }
         // -1 and +1
         if (
           node.initializer.type === AST_NODE_TYPES.UnaryExpression &&
diff --git a/packages/eslint-plugin/tests/rules/prefer-literal-enum-member.test.ts b/packages/eslint-plugin/tests/rules/prefer-literal-enum-member.test.ts
@@ -18,6 +18,11 @@ enum ValidString {
 }
     `,
     `
+enum ValidLiteral {
+  A = \`test\`,
+}
+    `,
+    `
 enum ValidNumber {
   A = 42,
 }
@@ -90,7 +95,7 @@ enum InvalidArray {
     {
       code: `
 enum InvalidTemplateLiteral {
-  A = \`a\`,
+  A = \`foo \${0}\`,
 }
       `,
       errors: [

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,11 @@ enum ValidString {`
`18`	`18`	`}`
`19`	`19`	`,
`20`	`20`	`
	`21`	`+enum ValidLiteral {`
	`22`	+ A = \`test\`,
	`23`	`+}`
	`24`	+ `,
	`25`	+ `
`21`	`26`	`enum ValidNumber {`
`22`	`27`	`A = 42,`
`23`	`28`	`}`
`@@ -90,7 +95,7 @@ enum InvalidArray {`
`90`	`95`	`{`
`91`	`96`	code: `
`92`	`97`	`enum InvalidTemplateLiteral {`
`93`		- A = \`a\`,
	`98`	+ A = \`foo \${0}\`,
`94`	`99`	`}`
`95`	`100`	`,
`96`	`101`	`errors: [`