Handle 304 responses from GitHub when users pass etag

sigmavirus24 · sigmavirus24 · commit d6c2a1cd9ff1 · 2018-03-19T19:18:51.000-05:00
This was an oversight in the behaviour of pre 1.0 _json handling. This commit makes it explicit and should allow it to continue working. Refs sigmavirus24gh-798
diff --git a/github3/models.py b/github3/models.py
@@ -154,9 +154,15 @@ def _json(self, response, expected_status_code, include_cache_info=True):
         if actual_status_code != expected_status_code:
             if actual_status_code >= 400:
                 raise exceptions.error_for(response)
+
+            if actual_status_code == 304:
+                # Received a response from someone passing in `etag=`
+                return None
+
             LOG.warning('Expected status_code %d but got %d',
                         expected_status_code,
                         actual_status_code)
+
         try:
             ret = response.json()
         except ValueError:
