Lint

domdfcoding · domdfcoding · commit 518b685d35e7 · 2023-06-02T09:08:23.000+01:00
diff --git a/domdf_python_tools/dates.py b/domdf_python_tools/dates.py
@@ -324,7 +324,8 @@ def is_bst(the_date: Union[time.struct_time, datetime.date]) -> bool:
 	"""
 	Calculates whether the given day falls within British Summer Time.
 
-	This function should also be applicable to other timezones which change to summer time on the same date (e.g. Central European Summer Time).
+	This function should also be applicable to other timezones
+	which change to summer time on the same date (e.g. Central European Summer Time).
 
 	.. note::
 
diff --git a/domdf_python_tools/pagesizes/__init__.py b/domdf_python_tools/pagesizes/__init__.py
@@ -39,7 +39,7 @@
 #
 
 # this package
-from .classes import *
-from .sizes import *
-from .units import *
-from .utils import *
+from .classes import *  # noqa: F401
+from .sizes import *  # noqa: F401
+from .units import *  # noqa: F401
+from .utils import *  # noqa: F401
diff --git a/domdf_python_tools/stringlist.py b/domdf_python_tools/stringlist.py
@@ -513,7 +513,7 @@ def splitlines(string: str) -> List[Tuple[str, str]]:
 	while i < str_len:
 
 		# Find a line and append it
-		while i < str_len and not string[i] in "\n\r":
+		while i < str_len and string[i] not in "\n\r":
 			i += 1
 
 		# Skip the line break reading CRLF as one line break
diff --git a/tests/test_namedlist.py b/tests/test_namedlist.py
@@ -82,7 +82,7 @@ class NamedListTest:
 	str_out = "ShoppingList['egg and bacon', 'egg sausage and bacon', 'egg and spam', 'egg bacon and spam']"
 	cls_str: str
 
-	def test(self, capsys):
+	def test_(self, capsys):
 		assert isinstance(self.shopping_list, UserList)
 		assert self.shopping_list[0] == "egg and bacon"
 
diff --git a/tests/test_pagesizes/test_pagesizes.py b/tests/test_pagesizes/test_pagesizes.py
@@ -178,7 +178,7 @@ def test_convert_size(unit: Unit):
 				pytest.param(2, 5, 10, id="not isinstance(from_, Unit)"),
 				],
 		)
-def test_convert_from(value: List[int], unit, expects: Tuple[float, ...]):
+def test_convert_from(value: List[int], unit: Unit, expects: Tuple[float, ...]):
 	assert convert_from(value, unit) == expects
 
 

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ def test_convert_size(unit: Unit):`
`178`	`178`	`pytest.param(2, 5, 10, id="not isinstance(from_, Unit)"),`
`179`	`179`	`],`
`180`	`180`	`)`
`181`		`-def test_convert_from(value: List[int], unit, expects: Tuple[float, ...]):`
	`181`	`+def test_convert_from(value: List[int], unit: Unit, expects: Tuple[float, ...]):`
`182`	`182`	`assert convert_from(value, unit) == expects`
`183`	`183`
`184`	`184`