8000 address review comments · domdfcoding/circuitpython@4608877 · GitHub
[go: up one dir, main page]

Skip to content

Commit 4608877

Browse files
committed
address review comments
1 parent 35aac3d commit 4608877

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

ports/raspberrypi/audio_dma.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ STATIC void audio_dma_load_next_block(audio_dma_t *dma, size_t buffer_idx) {
153153
}
154154

155155
// Convert the sample format resolution and signedness, as necessary.
156-
// The input sample buffer is what was read from a file or a raw sample buffer.
156+
// The input sample buffer is what was read from a file, Mixer, or a raw sample buffer.
157157
// The output buffer is one of the DMA buffers (passed in), or if no conversion was done,
158158
// the original sample buffer (to save copying).
159159

@@ -370,13 +370,6 @@ void audio_dma_stop(audio_dma_t *dma) {
370370
dma_channel_abort(channel);
371371
}
372372

373-
// Write a zero as the last sample. This stops any PWM output.
374-
if (dma->output_resolution <= 8) {
375-
*((uint8_t *)dma->output_register_address) = 0;
376-
} else {
377-
*((uint16_t *)dma->output_register_address) = 0;
378-
}
379-
380373
dma_channel_set_read_addr(channel, NULL, false /* trigger */);
381374
dma_channel_set_write_addr(channel, NULL, false /* trigger */);
382375
dma_channel_set_trans_count(channel, 0, false /* trigger */);

0 commit comments

Comments
 (0)
0