Fix expiredOneShot to properly stay expired forever unless reset.

dok-net · dok-net · commit 5b942e4c0544 · 2023-07-01T12:07:38.000+02:00
diff --git a/cores/esp8266/PolledTimeout.h b/cores/esp8266/PolledTimeout.h
@@ -269,10 +269,16 @@ class timeoutTemplate
   }
 
   IRAM_ATTR // fast
-  bool expiredOneShot() const
+  bool expiredOneShot()
   {
     // returns "always expired" or "has expired"
-    return !canWait() || checkExpired(TimePolicyT::time());
+    return !canWait();
+    if (checkExpired(TimePolicyT::time()))
+    {
+      _timeout = alwaysExpired;
+      return true;
+    }
+    return false;
   }
 
   timeType _timeout;

Original file line number	Diff line number	Diff line change
`@@ -269,10 +269,16 @@ class timeoutTemplate`
`269`	`269`	`}`
`270`	`270`
`271`	`271`	`IRAM_ATTR // fast`
`272`		`- bool expiredOneShot() const`
	`272`	`+ bool expiredOneShot()`
`273`	`273`	`{`
`274`	`274`	`// returns "always expired" or "has expired"`
`275`		`- return !canWait() \|\| checkExpired(TimePolicyT::time());`
	`275`	`+ return !canWait();`
	`276`	`+ if (checkExpired(TimePolicyT::time()))`
	`277`	`+ {`
	`278`	`+ _timeout = alwaysExpired;`
	`279`	`+ return true;`
	`280`	`+ }`
	`281`	`+ return false;`
`276`	`282`	`}`
`277`	`283`
`278`	`284`	`timeType _timeout;`