Test for non-zero before subtract should improve performance.

dok-net · dok-net · commit 3848ec2e7587 · 2020-05-31T13:35:52.000+02:00
diff --git a/cores/esp8266/core_esp8266_waveform.cpp b/cores/esp8266/core_esp8266_waveform.cpp
@@ -353,14 +353,14 @@ static ICACHE_RAM_ATTR void timer1Interrupt() {
             }
             else {
               int32_t dutyCcys = scaleCcys(wave.dutyCcys);
-              if (dutyCcys > wave.adjDutyCcys) {
+              if (dutyCcys <= wave.adjDutyCcys) {
+                dutyCcys >>= 1;
+                wave.adjDutyCcys -= dutyCcys;
+              }
+              else if (wave.adjDutyCcys) {
                 dutyCcys -= wave.adjDutyCcys;
                 wave.adjDutyCcys = 0;
               }
-              else {
-                wave.adjDutyCcys -= dutyCcys;
-                dutyCcys = 0;
-              }
               wave.endDutyCcy = now + dutyCcys;
               if (static_cast<int32_t>(wave.endDutyCcy - wave.nextPeriodCcy) > 0) {
                 wave.endDutyCcy = wave.nextPeriodCcy;
