8000 Comparing 3.8.3...3.8.4 · doctrine/dbal · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: doctrine/dbal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.8.3
Choose a base ref
...
head repository: doctrine/dbal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.8.4
Choose a head ref
  • 11 commits
  • 14 files changed
  • 7 contributors

Commits on Mar 5, 2024

  1. Fix double quote used wrongly for literal value in SqliteSchemaManager ( 

    #6325)

|      Q       |   A
|------------- | -----------
| Type         | bug
| Fixed issues | 

#### Summary

It seems PHP SQLite drivers allows `"` to be used to escape literal
values, but natively such syntax produces an sqlite parse error [1].

I have discovered this when analysing SQLite log, it is otherwise
tested.

I checked all other `"` in SQLite platform and manager and all of them
seems correct otherwise.

[1] https://dbfiddle.uk/KQAGp9Ea (notice the 2nd query is the same, but
uses `"` instead of `'`)
    @mvorisek
    mvorisek authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e33f663 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Spell which properly

    @greg0ire
    greg0ire committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9c2b00a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #6332 from greg0ire/witch-hunt 

    Spell which properly
    @SenseException
    SenseException authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    87785d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Add MariaDB 11.3 to the test matrix (#6342)

    @derrabus
    derrabus authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e5db00e View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Remove unused script 

    I forgot to remove it in e7aef4e.
    @greg0ire
    greg0ire committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a527330 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Document how to run integration tests locally 

    I am also replacing the commented out connection parameters in
phpunit.xml.dist with a link to this paragraph because they have
diverged from the one we use in the CI since f88dc28.
    @greg0ire
    greg0ire committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d5d4ed5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #6355 from greg0ire/doc-local-tests 

    Document how to run integration tests locally
    @greg0ire
    greg0ire authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    16cfdc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Ensure correct json default value normalization (#6358) 

    <!-- Fill in the relevant information below to help triage your pull
request. -->

|      Q       |   A
|------------- | -----------
| Type         | bug
| Fixed issues | #6357

#### Summary

`PostgreSQLSchemaManager::_getPortableTableColumnDefinition()` is
modified to call the private method `parseDefaultExpression()` on
default values for `JSON` field to correctly normalize doubled
single-quotes in json string value.

A test to cover this case is added.
    @sbuerk
    sbuerk authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e2a6621 View commit details
    Browse the repository at this point in the history

  2. Avoid calling deprecated Type::getName() (#6359) 

    Follow-up to #6358 (@sbuerk): `getName()` is gone on 4.0.x. This change
will make merging this test up easier for us.
    @derrabus
    derrabus authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    edbf307 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. [Docs] Update docs regarding "datetimetz" type (#6014)

    @phansys
    phansys authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ad2fee0 View commit details
    Browse the repository at this point in the history

  2. Connection::setNestTransactionsWithSavepoints() should not break lazy… 

    … connection (#6362)

|      Q       |   A
|------------- | -----------
| Type         | bug
| Fixed issues | N/A

#### Summary

When calling `Connection::setNestTransactionsWithSavepoints()`, the
platform is fetched to check if savepoints are actually supported. This
is a problem because it might cause the connection to be opened.

I've removed the check which will postpone the exception to the first
time we attempt to create a savepoint.
    @derrabus
    derrabus authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b05e48a View commit details
    Browse the repository at this point in the history
Loading
0