8000 Incompatibility with Symfony 4.3.10+ · Issue #616 · doctrine/DoctrineMongoDBBundle · GitHub
[go: up one dir, main page]

Skip to content
Incompatibility with Symfony 4.3.10+ #616
@excentrik

Description

@excentrik

Hello

In our company's project we are currently using Symfony 4.4 branch, but we are still behind in our move towards using Doctrine ODM 2.

Therefore we still rely on doctrine/mongodb-odm-bundle for the interface beween Symfony and doctrine odm 1.3.

Unfortunately, the PR symfony/symfony#34955 has broken interface compatibility between the doctrine/mongodb-odm-bundle and Symfony's latest versions (4.4.2+,4.3.10+,5.0.2+):

PHP Fatal error:  Declaration of Doctrine\Bundle\MongoDBBundle\Form\Type\DocumentType::getLoader(Doctrine\Common\Persistence\ObjectManager $manager, $queryBuilder, $class) 
must be compatible with Symfony\Bridge\Doctrine\Form\Type\DoctrineType::getLoader(Doctrine\Persistence\ObjectManager $manager, $queryBuilder, $class)

Since the interface is almost the same, I think the fix should be just changing the method Doctrine\Bundle\MongoDBBundle\Form\Type\DocumentType::getLoader to receive a Doctrine\Persistence\ObjectManager but I'm not sure if this would cause any other incompatibilities.

52A7

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0