8000 Add support for validator auto-mapping by dunglas · Pull Request #939 · doctrine/DoctrineBundle · GitHub
[go: up one dir, main page]
Skip to content

Add support for validator auto-mapping #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2019
Merged

Add support for validator auto-mapping #939

merged 2 commits into from
Apr 6, 2019

Conversation

dunglas
Copy link
Contributor
@dunglas dunglas commented Mar 31, 2019 •
edited
Loading

Adds support for symfony/symfony#27735 in the bundle.

Related config:

framework:
    validation:
        auto_mapping:
            App\Entity\: []

greg0ire
greg0ire reviewed Mar 31, 2019
View reviewed changes
@dunglas dunglas mentioned this pull request Mar 31, 2019
Closed
@dunglas
Copy link
Contributor Author
dunglas commented Mar 31, 2019 •
edited
Loading

I tested this PR on a real project, and it's working properly. CI failures are unrelated.

@dunglas dunglas changed the title Add support for validator automapping Add support for validator auto-mapping Mar 31, 2019
@Majkl578
Copy link
Contributor

and it's working properly

This will need some sort of test otherwise it can break in future. :|

@dunglas
Copy link
Contributor Author
dunglas commented Mar 31, 2019

Yes I totally agree. At least a functional test is mandatory.

@alcaeus alcaeus added the Feature label Apr 1, 2019
@alcaeus alcaeus added this to the 1.11.0 milestone Apr 1, 2019
@alcaeus alcaeus force-pushed the validator-automapping branch from af834d0 to 173b524 Compare April 2, 2019 12:13
@alcaeus alcaeus mentioned this pull request Apr 2, 2019
Closed
@alcaeus alcaeus requested a rev 8000 iew from greg0ire April 2, 2019 13:49
@alcaeus alcaeus force-pushed the validator-automapping branch from 173b524 to bfd2c59 Compare April 2, 2019 13:49
@alcaeus alcaeus assigned alcaeus and unassigned dunglas Apr 2, 2019
SenseException
SenseException requested changes Apr 2, 2019
View reviewed changes
Copy link
Member
@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A phpcs issue is still there. Otherwise this is 👍

greg0ire
greg0ire reviewed Apr 3, 2019
View reviewed changes
@alcaeus alcaeus force-pushed the validator-automapping branch from bfd2c59 to cb9758b Compare April 4, 2019 05:11
@alcaeus alcaeus requested a review from SenseException April 4, 2019 05:12
stof
stof requested changes Apr 4, 2019
View reviewed changes
@alcaeus alcaeus force-pushed the validator-automapping branch from cb9758b to 0eb42ea Compare April 4, 2019 11:16
@alcaeus alcaeus requested a review from stof April 4, 2019 11:18
@alcaeus alcaeus force-pushed the validator-automapping branch from 0eb42ea to 75c249b Compare April 6, 2019 09:18
@alcaeus alcaeus merged commit dfdb221 into doctrine:master Apr 6, 2019
@dunglas
Copy link
Contributor Author
dunglas commented Apr 6, 2019

Thanks a lot for finishing this one Andreas!

@alcaeus alcaeus added the ⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 7, 2019
@tarjei
Copy link
tarjei commented Jun 15, 2021

It seems that the blogpost for this feature has not been updated with the info about auto enabling it:
https://symfony.com/blog/new-in-symfony-4-3-automatic-validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@stof stof stof approved these changes

@SenseException SenseException SenseException approved these changes

Assignees

@alcaeus alcaeus

Labels
⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Feature
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@dunglas @Majkl578 @tarjei @stof @greg0ire @SenseException @alcaeus
0