8000 Rename "BlacklistSchemaAssetFilter" to match "WellKnownSchemaFilterPass" · Issue #1176 · doctrine/DoctrineBundle · GitHub
[go: up one dir, main page]

Skip to c 8000 ontent
Rename "BlacklistSchemaAssetFilter" to match "WellKnownSchemaFilterPass" #1176
@albe

Description

@albe

It just makes more sense. I suggest using "UnknownSchemaAssetFilter" instead - or probably even better "WellKnownSchemaAssetFilter", since it actually filters out well known assets. In case the filter itself should be more generic, "ExcludedSchemaAssetFilter" could work well, too.

TBD: Only change this in master or target lower. AFAIS it would only be breaking for 3rd parties that actually extend BlacklistSchemaAssetFilter or directly use it (could possibly be leviated by keeping an alias class around), but then this is a "glue" bundle, not a framework, so is this even API?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0